Fix jit.trace mis-handling of InterfaceType #53052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 49b18c8 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gmagogsfm
changed the title
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
wanchaol
approved these changes
Mar 1, 2021
`jit.trace` recursively gathers all named attributes in module at beginning of tracing. This is fine in a pure-tracing environment, but breaks when a scripted module that contains an InterfaceType'd submodule is involved. Because InterfaceType, by design, is not allowed to have any attribute, thus some of the gathered attributes will turn into fatal errors in following some graph rewrite passes. This PR fixes this bug by distinguishing InterfaceType'd submodules from normal ClassType'd submodules.
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #53052 +/- ##
=======================================
Coverage 78.00% 78.01%
=======================================
Files 1848 1848
Lines 179724 179726 +2
=======================================
+ Hits 140200 140205 +5
+ Misses 39524 39521 -3 |
|
@gmagogsfm merged this pull request in f448c59. |
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: `jit.trace` recursively gathers all named attributes in module at beginning of tracing. This is fine in a pure-tracing environment, but breaks when a scripted module that contains an InterfaceType'd submodule is involved. Because InterfaceType, by design, is not allowed to have any attribute, thus some of the gathered attributes will turn into fatal errors in following some graph rewrite passes. This PR fixes this bug by distinguishing InterfaceType'd submodules from normal ClassType'd submodules. Pull Request resolved: pytorch#53052 Reviewed By: wanchaol Differential Revision: D26735566 Pulled By: gmagogsfm fbshipit-source-id: a14aee6f1fe8000f80c2dc60bdf19acee6225090
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: `jit.trace` recursively gathers all named attributes in module at beginning of tracing. This is fine in a pure-tracing environment, but breaks when a scripted module that contains an InterfaceType'd submodule is involved. Because InterfaceType, by design, is not allowed to have any attribute, thus some of the gathered attributes will turn into fatal errors in following some graph rewrite passes. This PR fixes this bug by distinguishing InterfaceType'd submodules from normal ClassType'd submodules. Pull Request resolved: pytorch#53052 Reviewed By: wanchaol Differential Revision: D26735566 Pulled By: gmagogsfm fbshipit-source-id: a14aee6f1fe8000f80c2dc60bdf19acee6225090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jit.tracerecursively gathers all named attributes in module at beginning oftracing. This is fine in a pure-tracing environment, but breaks when a
scripted module that contains an InterfaceType'd submodule is involved.
Because InterfaceType, by design, is not allowed to have any attribute,
thus some of the gathered attributes will turn into fatal errors in
following some graph rewrite passes.
This PR fixes this bug by distinguishing InterfaceType'd submodules from
normal ClassType'd submodules.