New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradient Compression] Make GradBucket class public #53099
Conversation
Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 1341e73 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)
|
Job | Step | Action |
---|---|---|
pytorch_linux_bionic_py3_8_gcc9_coverage_test1 | Run tests | 🔁 rerun |
pytorch_linux_bionic_py3_8_gcc9_coverage_test2 | Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/) ghstack-source-id: 122723707 Pull Request resolved: #53099
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though could you post a screenshot of how the grad bucket docs are rendered?
It's not included in ddp_comm_hooks.rst. Will update the rst file in a separate PR. |
Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/) [ghstack-poisoned]
Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/) [ghstack-poisoned]
Pull Request resolved: #53099 Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket ghstack-source-id: 122997077 Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please make sure all tests pass before landing. Would also be great to expose this in the docs in a follow up change as you mentioend.
Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/) [ghstack-poisoned]
Pull Request resolved: #53099 Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket ghstack-source-id: 123030921 Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)
This pull request has been merged in 68b6249. |
Summary: Pull Request resolved: pytorch#53099 Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket ghstack-source-id: 123030921 Test Plan: waitforbuildbot Reviewed By: rohan-varma Differential Revision: D26721121 fbshipit-source-id: ee5f68e33095b9965b51937b86cdeb331fd2419a
Summary: Pull Request resolved: pytorch#53099 Publish GradBucket APIs for publishing DDP communication hooks. s/_GradBucket/GradBucket ghstack-source-id: 123030921 Test Plan: waitforbuildbot Reviewed By: rohan-varma Differential Revision: D26721121 fbshipit-source-id: ee5f68e33095b9965b51937b86cdeb331fd2419a
Stack from ghstack:
Publish GradBucket APIs for publishing DDP communication hooks.
s/_GradBucket/GradBucket
Differential Revision: D26721121