Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradient Compression] Make GradBucket class public #53099

Closed
wants to merge 4 commits into from

Conversation

wayi1
Copy link
Contributor

@wayi1 wayi1 commented Mar 2, 2021

Stack from ghstack:

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: D26721121

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 2, 2021

💊 CI failures summary and remediations

As of commit 1341e73 (more details on the Dr. CI page):


  • 5/5 failures possibly* introduced in this PR
    • 1/5 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1341e7382c Update on "[Gradient Compression] Make GradBucket class public"
+ git reset --hard 1341e7382cc8258a04bdf7941de9e1ec560534ee
HEAD is now at 1341e7382c Update on "[Gradient Compression] Make GradBucket class public"
+ git merge --allow-unrelated-histories --no-edit --no-ff 14a2ef09320814fb7f9a0084f1b9744edc816992
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Removing aten/src/ATen/native/vulkan/ops/Mul.cpp
Removing aten/src/ATen/native/vulkan/ops/Add.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1341e7382c Update on "[Gradient Compression] Make GradBucket class public"
+ git reset --hard 1341e7382cc8258a04bdf7941de9e1ec560534ee
HEAD is now at 1341e7382c Update on "[Gradient Compression] Make GradBucket class public"
+ git merge --allow-unrelated-histories --no-edit --no-ff 14a2ef09320814fb7f9a0084f1b9744edc816992
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Removing aten/src/ATen/native/vulkan/ops/Mul.cpp
Removing aten/src/ATen/native/vulkan/ops/Add.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


2 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_bionic_py3_8_gcc9_coverage_test1 Run tests 🔁 rerun
CircleCI pytorch_linux_bionic_py3_8_gcc9_coverage_test2 Run tests 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Mar 2, 2021
wayi1 pushed a commit that referenced this pull request Mar 2, 2021
Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)

ghstack-source-id: 122723707
Pull Request resolved: #53099
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though could you post a screenshot of how the grad bucket docs are rendered?

@wayi1
Copy link
Contributor Author

wayi1 commented Mar 2, 2021

Looks good, though could you post a screenshot of how the grad bucket docs are rendered?

It's not included in ddp_comm_hooks.rst. Will update the rst file in a separate PR.

@wayi1 wayi1 requested a review from rohan-varma March 3, 2021 05:07
Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)

[ghstack-poisoned]
Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Mar 3, 2021
Pull Request resolved: #53099

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket
ghstack-source-id: 122997077

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure all tests pass before landing. Would also be great to expose this in the docs in a follow up change as you mentioend.

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Mar 4, 2021
Pull Request resolved: #53099

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket
ghstack-source-id: 123030921

Differential Revision: [D26721121](https://our.internmc.facebook.com/intern/diff/D26721121/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 68b6249.

@facebook-github-bot facebook-github-bot deleted the gh/SciPioneer/71/head branch March 7, 2021 15:16
aocsa pushed a commit to Quansight/pytorch that referenced this pull request Mar 15, 2021
Summary:
Pull Request resolved: pytorch#53099

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket
ghstack-source-id: 123030921

Test Plan: waitforbuildbot

Reviewed By: rohan-varma

Differential Revision: D26721121

fbshipit-source-id: ee5f68e33095b9965b51937b86cdeb331fd2419a
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary:
Pull Request resolved: pytorch#53099

Publish GradBucket APIs for publishing DDP communication hooks.

s/_GradBucket/GradBucket
ghstack-source-id: 123030921

Test Plan: waitforbuildbot

Reviewed By: rohan-varma

Differential Revision: D26721121

fbshipit-source-id: ee5f68e33095b9965b51937b86cdeb331fd2419a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants