Move view handling logic to gen_inplace_or_view_type.py #53341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Mar 5, 2021
💊 CI failures summary and remediationsAs of commit 3d09115 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
added 4 commits
March 5, 2021 06:12
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
Test Plan: verified the generated VariableTypeEverything.cpp are the same after this PR. |
albanD
approved these changes
Mar 8, 2021
[ghstack-poisoned]
albanD
reviewed
Mar 10, 2021
| @@ -0,0 +1,268 @@ | |||
| from tools.codegen.api import cpp | |||
| from tools.codegen.api.autograd import * | |||
There was a problem hiding this comment.
nit: any plans where we can avoid these? :D
There was a problem hiding this comment.
I can fix all the new ones introduced in this PR and send out a followup PR to clean up the folder later ;)
But I didn't find a way to add this in flake8 so it'll be hard to prevent future changes :P
bhosmer
approved these changes
Mar 11, 2021
added 2 commits
March 11, 2021 07:59
[ghstack-poisoned]
Differential Revision: [D26973912](https://our.internmc.facebook.com/intern/diff/D26973912) [ghstack-poisoned]
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#53341 Test Plan: Imported from OSS Reviewed By: nikithamalgifb Differential Revision: D26973912 Pulled By: ailzhang fbshipit-source-id: ea31bdef0beac6996d509f5d45ebefa3ea8e2b89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D26973912