[iOS GPU] Support multi-dimension tensors via MPSImage #54106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The texture size will always be four dimensional. For higher dim tensors, we just fold them to the batch dim. Differential Revision: [D27033569](https://our.internmc.facebook.com/intern/diff/D27033569/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit b4ce191 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 16, 2021
SS-JIA
approved these changes
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## gh/xta0/94/base #54106 +/- ##
===================================================
- Coverage 77.33% 77.30% -0.03%
===================================================
Files 1888 1890 +2
Lines 185026 185077 +51
===================================================
- Hits 143090 143077 -13
- Misses 41936 42000 +64 |
The texture size will always be four dimensional. For higher dim tensors, we just fold them to the batch dim. Differential Revision: [D27033569](https://our.internmc.facebook.com/intern/diff/D27033569/) [ghstack-poisoned]
The texture size will always be four dimensional. For higher dim tensors, we just fold them to the batch dim. Differential Revision: [D27033569](https://our.internmc.facebook.com/intern/diff/D27033569/) [ghstack-poisoned]
|
This pull request has been merged in 2e8a9d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The texture size will always be four dimensional. For higher dim tensors, we just fold them to the batch dim.
Differential Revision: D27033569