Migrate kernels with Tensor? to C10 full dispatcher #54263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codemod commands generated by #54223 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit d2bb75b (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_bionic_py3_8_gcc9_coverage_test1 |
Run tests | 🔁 rerun |
| pytorch_linux_bionic_py3_8_gcc9_coverage_test2 |
Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
wenleix
commented
Mar 18, 2021
| IntArrayRef padding, IntArrayRef output_padding, IntArrayRef stride, IntArrayRef dilation, | ||
| int64_t groups, bool benchmark, bool deterministic) { | ||
| const Tensor& bias = c10::value_or_else(bias_opt, [] {return Tensor();}); |
There was a problem hiding this comment.
Will clean up such cases (i.e. the impl just raises an error) in a separate pass.
Codemod commands generated by #54223 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
… to C10 full dispatcher" Codemod commands generated by #54223 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 18, 2021
Pull Request resolved: #54263 Codemod commands generated by #54223 ghstack-source-id: 124314500 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/)
Codemod commands generated by #54223 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 19, 2021
Pull Request resolved: #54263 Codemod commands generated by #54223 ghstack-source-id: 124360597 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/)
smessmer
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Looks great :)
Maybe we should also add a small comment marker into the kernels so that if we ever want to clean them up further (i.e. have the kernel handle optional directly without going through the creation of a default constructed tensor), we know how to find them.
Maybe something like
Tensor my_op(...) {
// See [Note: hacky_wrapper_removal]
Tensor weight = value_or_else(...)
...
}
and then add a [Note: hacky_wrapper_removal] somewhere in a central location.
…cher" Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 20, 2021
Pull Request resolved: #54263 Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` ghstack-source-id: 124460153 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/)
… Tensor? to C10 full dispatcher" Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 22, 2021
Pull Request resolved: #54263 Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` ghstack-source-id: 124535551 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/)
…C10 full dispatcher" Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 22, 2021
Pull Request resolved: #54263 Codemod commands generated by #54223 Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are manually changed. ``` _thnn_multi_margin_loss_forward _thnn_multi_margin_loss_backward _thnn_nll_loss_forward _thnn_nll_loss_backward _thnn_nll_loss2d_forward _thnn_nll_loss2d_backward _thnn_conv2d_forward _thnn_conv_depthwise2d_forward ``` ghstack-source-id: 124539990 Differential Revision: [D27164092](https://our.internmc.facebook.com/intern/diff/D27164092/)
|
This pull request has been merged in edfc787. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Codemod commands generated by #54223
Signatures of the following 8 methods in LegacyTHFunctionsCUDA.h are
manually changed.
Differential Revision: D27164092