Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Process const folding progressively when converts to ONNX #54569

Merged
merged 2 commits into from Apr 28, 2021

Conversation

jiafatom
Copy link
Contributor

@jiafatom jiafatom commented Mar 24, 2021

This PR automatically solves onnx const attribute issue in PR #53784.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Mar 24, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2021

💊 CI failures summary and remediations

As of commit 7ff428c (more details on the Dr. CI page):



🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 28 15:17:06 sccache: error: couldn't connect to server
Apr 28 15:17:06 +++ eval 'extract_trap_cmd '
Apr 28 15:17:06 ++++ extract_trap_cmd
Apr 28 15:17:06 ++++ printf '%s\n' ''
Apr 28 15:17:06 +++ printf '%s\n' cleanup
Apr 28 15:17:06 ++ trap -- '
Apr 28 15:17:06 cleanup' EXIT
Apr 28 15:17:06 ++ [[ pytorch-linux-backward-compatibility-check-test != *pytorch-win-* ]]
Apr 28 15:17:06 ++ which sccache
Apr 28 15:17:06 ++ sccache --stop-server
Apr 28 15:17:06 Stopping sccache server...
Apr 28 15:17:06 sccache: error: couldn't connect to server
Apr 28 15:17:06 sccache: caused by: Connection refused (os error 111)
Apr 28 15:17:06 ++ true
Apr 28 15:17:06 ++ rm /var/lib/jenkins/sccache_error.log
Apr 28 15:17:06 ++ [[ -n '' ]]
Apr 28 15:17:06 ++ [[ pytorch-linux-backward-compatibility-check-test == *rocm* ]]
Apr 28 15:17:06 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 28 15:17:06 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 28 15:17:06 ++ RUST_LOG=sccache::server=error
Apr 28 15:17:06 ++ sccache --start-server
Apr 28 15:17:06 sccache: Starting the server...

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (2/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 28 15:17:28 sccache: error: couldn't connect to server
Apr 28 15:17:28 +++ eval 'extract_trap_cmd '
Apr 28 15:17:28 ++++ extract_trap_cmd
Apr 28 15:17:28 ++++ printf '%s\n' ''
Apr 28 15:17:28 +++ printf '%s\n' cleanup
Apr 28 15:17:28 ++ trap -- '
Apr 28 15:17:28 cleanup' EXIT
Apr 28 15:17:28 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test != *pytorch-win-* ]]
Apr 28 15:17:28 ++ which sccache
Apr 28 15:17:28 ++ sccache --stop-server
Apr 28 15:17:28 Stopping sccache server...
Apr 28 15:17:28 sccache: error: couldn't connect to server
Apr 28 15:17:28 sccache: caused by: Connection refused (os error 111)
Apr 28 15:17:28 ++ true
Apr 28 15:17:28 ++ rm /var/lib/jenkins/sccache_error.log
Apr 28 15:17:28 ++ [[ -n '' ]]
Apr 28 15:17:28 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test == *rocm* ]]
Apr 28 15:17:28 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 28 15:17:28 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 28 15:17:28 ++ RUST_LOG=sccache::server=error
Apr 28 15:17:28 ++ sccache --start-server
Apr 28 15:17:28 sccache: Starting the server...

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_jit_legacy_test (3/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 28 15:17:10 sccache: error: couldn't connect to server
Apr 28 15:17:10 +++ eval 'extract_trap_cmd '
Apr 28 15:17:10 ++++ extract_trap_cmd
Apr 28 15:17:10 ++++ printf '%s\n' ''
Apr 28 15:17:10 +++ printf '%s\n' cleanup
Apr 28 15:17:10 ++ trap -- '
Apr 28 15:17:10 cleanup' EXIT
Apr 28 15:17:10 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-jit_legacy-test != *pytorch-win-* ]]
Apr 28 15:17:10 ++ which sccache
Apr 28 15:17:10 ++ sccache --stop-server
Apr 28 15:17:10 Stopping sccache server...
Apr 28 15:17:10 sccache: error: couldn't connect to server
Apr 28 15:17:10 sccache: caused by: Connection refused (os error 111)
Apr 28 15:17:10 ++ true
Apr 28 15:17:10 ++ rm /var/lib/jenkins/sccache_error.log
Apr 28 15:17:10 ++ [[ -n '' ]]
Apr 28 15:17:10 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-jit_legacy-test == *rocm* ]]
Apr 28 15:17:10 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 28 15:17:10 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 28 15:17:10 ++ RUST_LOG=sccache::server=error
Apr 28 15:17:10 ++ sccache --start-server
Apr 28 15:17:10 sccache: Starting the server...

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@jiafatom jiafatom force-pushed the if_block branch 7 times, most recently from 545309b to acac432 Compare March 26, 2021 05:16
@jiafatom jiafatom force-pushed the if_block branch 5 times, most recently from 1219497 to c496c5f Compare March 29, 2021 16:39
@jiafatom jiafatom changed the title [WIP][ONNX] if block [WIP][ONNX] Process const folding progressively when converts to ONNX Mar 29, 2021
@jiafatom jiafatom force-pushed the if_block branch 12 times, most recently from dd45450 to 12e1094 Compare March 31, 2021 03:37
BowenBao added a commit that referenced this pull request May 7, 2021
…o ONNX (#54569)"

This PR automatically solves onnx const attribute issue in PR #53784.

Co-authored-by: David <jiafa@microsoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request May 11, 2021
…o ONNX (#54569)"

This PR automatically solves onnx const attribute issue in PR #53784.

Co-authored-by: David <jiafa@microsoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request May 11, 2021
…o ONNX (#54569)"

This PR automatically solves onnx const attribute issue in PR #53784.

Co-authored-by: David <jiafa@microsoft.com>

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request May 13, 2021
) (#57601)

Summary:
Pull Request resolved: #57601

This PR automatically solves onnx const attribute issue in PR #53784.

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D28393525

Pulled By: SplitInfinity

fbshipit-source-id: 833dac7c71f24a88af62d5dd2be0a702ed34d053

Co-authored-by: David <jiafa@microsoft.com>
BowenBao added a commit to BowenBao/pytorch that referenced this pull request May 14, 2021
…orch#54569)

This PR automatically solves onnx const attribute issue in PR pytorch#53784.

Co-authored-by: David <jiafa@microsoft.com>

ghstack-source-id: 3115389cdcb47c8e7a1c8722b254dd52491ed9e5
Pull Request resolved: pytorch#57601
facebook-github-bot pushed a commit that referenced this pull request May 14, 2021
… ONNX (#54569)"

Summary: Original commit changeset: 833dac7c71f2

Test Plan:
```
buck test mode/dev //pytext/fb/assistant/lite/test:test -- --exact
'pytext/fb/assistant/lite/test:test - test_export_bytes_model_to_caffe2
(pytext.fb.assistant.lite.test.test.TestExport)'
```

Reviewed By: jeanm

Differential Revision: D28431840

fbshipit-source-id: 0f1d530034404421a5d51691173e1cc0ee16fdd6
jiafatom added a commit to jiafatom/pytorch that referenced this pull request May 16, 2021
…orch#54569)

This PR automatically solves onnx const attribute issue in PR pytorch#53784.

Co-authored-by: David <jiafa@microsoft.com>
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
…orch#54569) (pytorch#57601)

Summary:
Pull Request resolved: pytorch#57601

This PR automatically solves onnx const attribute issue in PR pytorch#53784.

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D28393525

Pulled By: SplitInfinity

fbshipit-source-id: 833dac7c71f24a88af62d5dd2be0a702ed34d053

Co-authored-by: David <jiafa@microsoft.com>
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
… ONNX (pytorch#54569)"

Summary: Original commit changeset: 833dac7c71f2

Test Plan:
```
buck test mode/dev //pytext/fb/assistant/lite/test:test -- --exact
'pytext/fb/assistant/lite/test:test - test_export_bytes_model_to_caffe2
(pytext.fb.assistant.lite.test.test.TestExport)'
```

Reviewed By: jeanm

Differential Revision: D28431840

fbshipit-source-id: 0f1d530034404421a5d51691173e1cc0ee16fdd6
SplitInfinity pushed a commit that referenced this pull request May 25, 2021
…onverts to ONNX (#54569)""

Original commit changeset: c54597b2048e

Differential Revision: [D28432555](https://our.internmc.facebook.com/intern/diff/D28432555/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28432555/)!

[ghstack-poisoned]
SplitInfinity pushed a commit that referenced this pull request May 25, 2021
…onverts to ONNX (#54569)""

Original commit changeset: c54597b2048e

Differential Revision: [D28432555](https://our.internmc.facebook.com/intern/diff/D28432555/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28432555/)!

ghstack-source-id: 129842041
Pull Request resolved: #58923
facebook-github-bot pushed a commit that referenced this pull request May 26, 2021
…onverts to ONNX (#54569)"" (#58923)

Summary:
Pull Request resolved: #58923

Original commit changeset: c54597b2048e
ghstack-source-id: 129842041

Test Plan: Sandcastle and OSS CI.

Reviewed By: snisarg

Differential Revision: D28432555

fbshipit-source-id: 2a9ec22cc004c7c6979f1cc8f3124b833cdc6634
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
…onverts to ONNX (pytorch#54569)"" (pytorch#58923)

Summary:
Pull Request resolved: pytorch#58923

Original commit changeset: c54597b2048e
ghstack-source-id: 129842041

Test Plan: Sandcastle and OSS CI.

Reviewed By: snisarg

Differential Revision: D28432555

fbshipit-source-id: 2a9ec22cc004c7c6979f1cc8f3124b833cdc6634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants