[PyTorch] Reapply D27404164: Devirtualize is_contiguous #55333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reapplying without using enum class in a bitfield. See new comments about gcc bug. Differential Revision: [D27576623](https://our.internmc.facebook.com/intern/diff/D27576623/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27576623/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 81e4c2b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…27404164: Devirtualize is_contiguous" Reapplying without using enum class in a bitfield. See new comments about gcc bug. Differential Revision: [D27576623](https://our.internmc.facebook.com/intern/diff/D27576623/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27576623/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Apr 5, 2021
Pull Request resolved: #55333 Reapplying without using enum class in a bitfield. See new comments about gcc bug. ghstack-source-id: 125776904 Differential Revision: [D27576623](https://our.internmc.facebook.com/intern/diff/D27576623/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27576623/)!
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/195/base #55333 +/- ##
========================================================
- Coverage 77.48% 77.48% -0.01%
========================================================
Files 1895 1895
Lines 187204 187212 +8
========================================================
+ Hits 145050 145055 +5
- Misses 42154 42157 +3 |
kimishpatel
approved these changes
Apr 6, 2021
bhosmer
approved these changes
Apr 6, 2021
|
This pull request has been merged in d6cbecb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Reapplying without using enum class in a bitfield. See new
comments about gcc bug.
Differential Revision: D27576623
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!