add dtype information for input #55358
Conversation
💊 CI failures summary and remediationsAs of commit 83af5a5 (more details on the Dr. CI page):
2 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #55358 +/- ##
===========================================
+ Coverage 41.96% 77.03% +35.06%
===========================================
Files 581 1924 +1343
Lines 73430 190616 +117186
===========================================
+ Hits 30813 146834 +116021
- Misses 42617 43782 +1165 |
guotuofeng
requested review from
BowenBao,
ezyang,
glaringlee,
H-Huang,
jbschlosser,
mingzhe09088,
mrshenli,
neginraoof,
pritamdamania87,
rohan-varma,
wayi1,
spandantiwari and
zhaojuanmao
as code owners
ngimel
removed request for
jbschlosser,
mingzhe09088,
mrshenli,
neginraoof,
pritamdamania87,
rohan-varma,
wayi1,
spandantiwari and
zhaojuanmao
ngimel
added
the
triaged
|
Thank you, looks good, modulo one minor comment. Also there might be some (trivial) merge conflict, so please rebase and we'll continue with landing. |
|
@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| types.reserve(fn.inputs().size()); | ||
| for (const c10::IValue& input : fn.inputs()) { | ||
| if (!input.isTensor()) { | ||
| types.emplace_back(); |
There was a problem hiding this comment.
Also, do we care about list types?
There was a problem hiding this comment.
From the time being, we only need care about scalar and tensor. What kind of scenarios that do we need care about list?
|
@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ilia-cher merged this pull request in 28f5264. |
Summary: add dtype for all input besides input dimenstion. Pull Request resolved: pytorch#55358 Reviewed By: heitorschueroff Differential Revision: D27862346 Pulled By: ilia-cher fbshipit-source-id: 656c5d6c9f23d723b27b44f0afc1a249ce1f3e44
add dtype for all input besides input dimenstion.