Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize floating point floor_divide #55380

Closed
wants to merge 6 commits into from

Conversation

peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Apr 6, 2021

Stack from ghstack:

Differential Revision: D27993499

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2021

💊 CI failures summary and remediations

As of commit 968282f (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@peterbell10
Copy link
Collaborator Author

@mruberry PTAL

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mruberry
Copy link
Collaborator

Android builds are upset about the "unused" alias:

aten/src/ATen/native/cpu/BinaryOpsKernel.cpp:169:13: error: unused type alias 'vec_t' [-Werror,-Wunused-local-typedef]
      using vec_t = Vec256<scalar_t>;

@peterbell10
Copy link
Collaborator Author

@mruberry I removed the duplicate vec_t alias. Should be good now.

@mruberry
Copy link
Collaborator

@mruberry I removed the duplicate vec_t alias. Should be good now.

Looks like the issue has been addressed. Landing now.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in a18f3aa.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/55/head branch May 1, 2021 14:16
crcrpar pushed a commit to crcrpar/pytorch that referenced this pull request May 7, 2021
Summary: Pull Request resolved: pytorch#55380

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27993499

Pulled By: mruberry

fbshipit-source-id: 45ea9c3295e4d85316bae9487db20914e0cbe3ed
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary: Pull Request resolved: pytorch#55380

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27993499

Pulled By: mruberry

fbshipit-source-id: 45ea9c3295e4d85316bae9487db20914e0cbe3ed
jasperzhong pushed a commit to jasperzhong/swift that referenced this pull request Nov 25, 2021
ghstack-source-id: 440294b29cd728ba65eda4f69852f5790ceb5c7b
Pull Request resolved: pytorch/pytorch#55380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants