[quant][graphmode][fx] Separate handling Copy operator to a helper function (#54644) #55429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction (#54644) Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 88023a1 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
added a commit
that referenced
this pull request
Apr 6, 2021
…nction (#54644) Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo ghstack-source-id: 48f3ea021a3518e5b10f3fe112fa5c1141f2c63c Pull Request resolved: #55429
vkuzo
reviewed
Apr 7, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
commented
Apr 7, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
vkuzo
reviewed
Apr 8, 2021
vkuzo
reviewed
Apr 8, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
vkuzo
approved these changes
Apr 8, 2021
|
This pull request has been merged in 4d449f9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously we special case copy operator in normal insert observer code, this PR tries to split the
special case logic to a separate function and keep the rest of the code clean.
Test Plan: Imported from OSS
Reviewed By: vkuzo
Differential Revision: D27609972