[torch/elastic] Revise the rendezvous handler registry logic. #55466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbalioglu
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 14d1f84 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D27623215 |
…h#55466) Summary: Pull Request resolved: pytorch#55466 Improve the implementation and the unit test coverage of `RendezvousHandlerRegistry`. ### Note See the original diff (D27442325 (pytorch@df299db)) that had to be reverted due to an unexpected Python version incompatibility between the internal and external PyTorch CI tests. Test Plan: Run the existing and newly-introduced unit tests. Differential Revision: D27623215 fbshipit-source-id: fd31db5373793396124df02f83c1d4c420142f04
cbalioglu
force-pushed
the
export-D27623215
branch
from
c362aab
to
14d1f84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D27623215 |
Codecov Report
@@ Coverage Diff @@
## master #55466 +/- ##
==========================================
- Coverage 77.41% 76.99% -0.43%
==========================================
Files 1895 1895
Lines 187583 187593 +10
==========================================
- Hits 145215 144433 -782
- Misses 42368 43160 +792 |
|
This pull request has been merged in 493a233. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improve the implementation and the unit test coverage of
RendezvousHandlerRegistry.Note
See the original diff (D27442325 (df299db)) that had to be reverted due to an unexpected Python version incompatibility between the internal and external PyTorch CI tests.
Test Plan: Run the existing and newly-introduced unit tests.
Differential Revision: D27623215