[torch/elastic] Introduce EtcdRendezvousBackend.
#55637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
cbalioglu
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit 7567c0d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 8, 2021
cbalioglu
added a commit
that referenced
this pull request
Apr 8, 2021
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! ghstack-source-id: 126088124 Pull Request resolved: #55637
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
cbalioglu
added a commit
that referenced
this pull request
Apr 9, 2021
Pull Request resolved: #55637 This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). ghstack-source-id: 126129041 Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)!
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
cbalioglu
added a commit
that referenced
this pull request
Apr 12, 2021
Pull Request resolved: #55637 This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DefaultRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). ghstack-source-id: 126304804 Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)!
This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DynamicRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)! [ghstack-poisoned]
cbalioglu
added a commit
that referenced
this pull request
Apr 12, 2021
Pull Request resolved: #55637 This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DynamicRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). ghstack-source-id: 126312209 Differential Revision: [D27654498](https://our.internmc.facebook.com/intern/diff/D27654498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27654498/)!
aivanou
approved these changes
Apr 12, 2021
|
This pull request has been merged in e61b4fa. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#55637 This diff introduces the `EtcdRendezvousBackend` type that will serve as an experimental alternative to the existing `EtcdRendezvousHandler`. The major advantage of `EtcdRendezvousBackend` is that it delegates the bulk of the rendezvous handling logic to `DynamicRendezvousHandler` which is shared with `C10dRendezvousBackend` (see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3). ghstack-source-id: 126312209 Test Plan: Run the existing and newly-introduced unit/integration tests. Reviewed By: tierex Differential Revision: D27654498 fbshipit-source-id: f3259adfc9068b7e323b947a7d8d52fcd0b8ada1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
EtcdRendezvousBackend. #55637 [torch/elastic] IntroduceEtcdRendezvousBackend.C10dRendezvousBackend. #55636 [torch/elastic] IntroduceC10dRendezvousBackend.DynamicRendezvousHandlerandRendezvousBackend. #55635 [torch/elastic] IntroduceDynamicRendezvousHandlerandRendezvousBackend.This diff introduces the
EtcdRendezvousBackendtype that will serve as an experimental alternative to the existingEtcdRendezvousHandler.The major advantage of
EtcdRendezvousBackendis that it delegates the bulk of the rendezvous handling logic toDynamicRendezvousHandlerwhich is shared withC10dRendezvousBackend(see D27654492) and any other potential future rendezvous backend (e.g. Amazon S3).Differential Revision: D27654498
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!