[package] make GlobGroup a public concept #56238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already functionally public due to `extern` and `mock`, but exposing the underlying implementation makes extending PackageExporter easier. Changed the underscores, expose on `torch.package`, add docs, etc. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ce3b547 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
It's already functionally public due to `extern` and `mock`, but exposing the underlying implementation makes extending PackageExporter easier. Changed the underscores, expose on `torch.package`, add docs, etc. Differential Revision: [D27817013](https://our.internmc.facebook.com/intern/diff/D27817013) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 16, 2021
It's already functionally public due to `extern` and `mock`, but exposing the underlying implementation makes extending PackageExporter easier. Changed the underscores, expose on `torch.package`, add docs, etc. ghstack-source-id: 7e9a3895ed0575e787d6836bdcf370c38d8909f7 Pull Request resolved: #56238
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56238 It's already functionally public due to `extern` and `mock`, but exposing the underlying implementation makes extending PackageExporter easier. Changed the underscores, expose on `torch.package`, add docs, etc. Differential Revision: D27817013 Test Plan: Imported from OSS Reviewed By: Lilyjjo Pulled By: suo fbshipit-source-id: e39199e7cb5242a8bfb815777e4bb82462864027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It's already functionally public due to
externandmock, butexposing the underlying implementation makes extending PackageExporter
easier.
Changed the underscores, expose on
torch.package, add docs, etc.Differential Revision: D27817013