Use stack trace implementation in common/process on fbcode #56400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #56399 I don't have time to fix this properly, so this is just to stem the bleeding. Someone should go and figure out what it is that common/process is doing better. Differential Revision: [D27861908](https://our.internmc.facebook.com/intern/diff/D27861908/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27861908/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 8ccdce0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ezyang
added a commit
that referenced
this pull request
Apr 19, 2021
See #56399 I don't have time to fix this properly, so this is just to stem the bleeding. Someone should go and figure out what it is that common/process is doing better. Differential Revision: [D27861908](https://our.internmc.facebook.com/intern/diff/D27861908/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27861908/)! ghstack-source-id: 126868405 Pull Request resolved: #56400
driazati
approved these changes
Apr 19, 2021
|
This pull request has been merged in b1282bc. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…6400) Summary: Pull Request resolved: pytorch#56400 See pytorch#56399 I don't have time to fix this properly, so this is just to stem the bleeding. Someone should go and figure out what it is that common/process is doing better. ghstack-source-id: 126868405 Test Plan: I manually patched this into D27765125 and triggered a exception and observed that everything symbolized good: ``` [9] what(): new_refcount != 1INTERNAL ASSERT FAILED at "caffe2/c10/util/intrusive_ptr.h":234, please report a bug to PyTorch. intrusive_ptr: Cannot increase refcount after it reached zero. Exception raised from retain_ at caffe2/c10/util/intrusive_ptr.h:234 (most recent call first): # 0 c10::get_backtrace[abi:cxx11](unsigned long, unsigned long, bool) # 1 c10::(anonymous namespace)::GetFetchStackTrace[abi:cxx11]()::$_0::operator()[abi:cxx11]() const # 2 std::_Function_handler<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > (), c10::(anonymous namespace)::Ge tFetchStackTrace()::$_0>::_M_invoke(std::_Any_data const&) # 3 std::function<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > ()>::operator()() const # 4 c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) # 5 c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocat or<char> > const&) # 6 c10::detail::torchInternalAssertFail(char const*, char const*, unsigned int, char const*, char const*) # 7 c10::intrusive_ptr<c10d::ProcessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessGroup> >::retain_() # 8 c10::intrusive_ptr<c10d::ProcessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessGroup> >::intrusive_ptr(c10::intrusiv e_ptr<c10d::ProcessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessGroup> > const&) # 9 c10::intrusive_ptr<c10d::ProcessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessGroup> >& c10::intrusive_ptr<c10d::Pr ocessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessGroup> >::operator=<c10d::ProcessGroup, c10::detail::intrusive_target _default_null_type<c10d::ProcessGroup> >(c10::intrusive_ptr<c10d::ProcessGroup, c10::detail::intrusive_target_default_null_type<c10d::ProcessG roup> > const&) & ``` Reviewed By: driazati Differential Revision: D27861908 fbshipit-source-id: 84c1dfb1ef28c460b020646f836c153562ad5c44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
See #56399
I don't have time to fix this properly, so this is just to stem the
bleeding. Someone should go and figure out what it is that common/process
is doing better.
Differential Revision: D27861908
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!