Separate profiling tests from p2p tests #56412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 6064935 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
cla signed
oncall: distributed
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/) [ghstack-poisoned]
mrshenli
reviewed
Apr 19, 2021
| rank = dist.get_rank() | ||
| send_size = rank + 1 | ||
| tensor = _build_tensor(send_size) | ||
| with torch.autograd.profiler.profile(record_shapes=True) as prof: | ||
| profile_ctx = ( |
There was a problem hiding this comment.
this occurs multiple times, shall we dedup this?
| frequency = [len(list(group)) for key, group in groupby(global_recv_ranks_list)] | ||
| self.assertEqual(dist.get_world_size(), len(frequency)) | ||
| self.assertEqual([2 * (dist.get_world_size() - 1)] * dist.get_world_size(), frequency) | ||
| self._barrier() |
There was a problem hiding this comment.
this barrier is only needed for the profiler enabled case?
There was a problem hiding this comment.
It looks like test_send_recv_nccl has this without profiling tests, hence thought we should keep it here as well. Although maybe that test copied the barrier from this test and it's not needed when profiler is not enabled.
Actually looking at this a bit more, I don't think _barrier() is needed at all since send/recv are issued in blocking fashion and _barrier doesn't provide anything extra here. I think it's better to just remove it.
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/) [ghstack-poisoned]
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 19, 2021
Pull Request resolved: #56412 We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. ghstack-source-id: 126894186 Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/)
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 20, 2021
Pull Request resolved: #56412 We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. ghstack-source-id: 126920867 Differential Revision: [D27864845](https://our.internmc.facebook.com/intern/diff/D27864845/)
|
This pull request has been merged in 04de24d. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56412 We are investigating some flaky profiiling tests such as pytorch#56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests. To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled. ghstack-source-id: 126920867 Test Plan: CI Reviewed By: mrshenli Differential Revision: D27864845 fbshipit-source-id: 01f04a884482ec7741323218a7f8f4a8451eb4ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We are investigating some flaky profiiling tests such as #56146. One issue is that the profiling tests are tightly coupled to these send/recv tests, hence if this test is disabled, we lose signal round send/recv collectives tests.
To mitigate this, separate the tests into ones that only test send/recv, and ones that test it with profiling. This way flakiness should not result in the send/recv only tests being disabled.
Differential Revision: D27864845