Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xnnpack hardswish op (#55800) #56714

Closed
wants to merge 1 commit into from

Conversation

axitkhurana
Copy link
Contributor

Summary:
Pull Request resolved: #55800

For mobile use xnnpack implementation of hardswish

Test Plan: buck run //xplat/caffe2:pt_xnnpack_test_bin

Differential Revision: D27712306

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 22, 2021

💊 CI failures summary and remediations

As of commit 56a8c4b (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_windows_libtorch_3_7_cpu_debug_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

FAILED: caffe2/CMakeFiles/torch_cpu.dir/opt/fusion.cc.obj
[3440/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\quantization\server\dynamic_histogram.cc.obj
[3441/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\distributed_converter.cc.obj
[3442/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\distributed.cc.obj
[3443/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\backend_transformer_base.cc.obj
[3444/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\bound_shape_inferencer.cc.obj
[3445/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\dead_code_elim.cc.obj
[3446/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\mobile.cc.obj
[3447/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\fakefp16_transform.cc.obj
[3448/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\glow_net_transform.cc.obj
[3449/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\fusion.cc.obj
FAILED: caffe2/CMakeFiles/torch_cpu.dir/opt/fusion.cc.obj 
C:\w\b\windows\tmp_bin\sccache-cl.exe  /nologo /TP -DCPUINFO_SUPPORTED_PLATFORM=1 -DFMT_HEADER_ONLY=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTH_BLAS_MKL -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -Dtorch_cpu_EXPORTS -Iaten\src -I..\..\aten\src -I. -I..\..\ -I..\..\cmake\..\third_party\benchmark\include -Icaffe2\contrib\aten -I..\..\third_party\onnx -Ithird_party\onnx -I..\..\third_party\foxi -Ithird_party\foxi -I..\..\torch\csrc\api -I..\..\torch\csrc\api\include -I..\..\caffe2\aten\src\TH -Icaffe2\aten\src\TH -Icaffe2\aten\src -Icaffe2\..\aten\src -Icaffe2\..\aten\src\ATen -I..\..\torch\csrc -I..\..\third_party\miniz-2.0.8 -I..\..\aten\src\TH -I..\..\aten\..\third_party\catch\single_include -I..\..\aten\src\ATen\.. -Icaffe2\aten\src\ATen -I..\..\caffe2\core\nomnigraph\include -I..\..\c10\.. -Ithird_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\mkl-dnn\src\..\include -I..\..\third_party\pthreadpool\include -I..\..\third_party\cpuinfo\include -I..\..\third_party\fbgemm\include -I..\..\third_party\fbgemm -I..\..\third_party\fbgemm\third_party\asmjit\src -I..\..\third_party\FP16\include -I..\..\third_party\fmt\include -Ithird_party\gloo -I..\..\cmake\..\third_party\gloo -I..\..\cmake\..\third_party\googletest\googlemock\include -I..\..\cmake\..\third_party\googletest\googletest\include -I..\..\third_party\protobuf\src -IC:\w\b\windows\mkl\include -I..\..\third_party\XNNPACK\include -I..\..\third_party -I..\..\cmake\..\third_party\eigen -I..\..\cmake\..\third_party\pybind11\include -I..\..\third_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\include -I..\..\caffe2 /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/w/b/windows/mkl/include -DUSE_FBGEMM -DUSE_XNNPACK -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MDd /Z7 /Ob0 /Od /RTC1 /w /bigobj -DCAFFE2_USE_GLOO -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -openmp:experimental -IC:/w/b/windows/mkl/include -DCAFFE2_BUILD_MAIN_LIB -DONNX_BUILD_MAIN_LIB -std:c++14 /showIncludes /Focaffe2\CMakeFiles\torch_cpu.dir\opt\fusion.cc.obj /Fdcaffe2\CMakeFiles\torch_cpu.dir\ /FS -c ..\..\caffe2\opt\fusion.cc
sccache: encountered fatal error
sccache: error : Invalid checksum
sccache:  cause: Invalid checksum
[3450/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\__\torch\csrc\jit\passes\quantization\fusion_passes.cpp.obj
[3451/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\optimizer.cc.obj
[3452/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\passes.cc.obj
[3453/4217] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\opt\onnxifi_op.cc.obj
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\xstddef(251): warning C4018: '>=': signed/unsigned mismatch
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\xstddef(250): note: while compiling class template member function 'bool std::greater_equal<void>::operator ()<const T1&,const T2&>(_Ty1,_Ty2) noexcept(<expr>) const'

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27712306

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27712306

Summary:
Pull Request resolved: pytorch#56714

Pull Request resolved: pytorch#55800

For mobile use xnnpack implementation of hardswish

Test Plan: buck test //xplat/caffe2:pt_xnnpack_test

Reviewed By: kimishpatel

Differential Revision: D27712306

fbshipit-source-id: 07afe20acc69caed39ee04b18205fbd7ce747344
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27712306

axitkhurana added a commit to axitkhurana/pytorch that referenced this pull request Apr 26, 2021
Summary:
Pull Request resolved: pytorch#56714

Pull Request resolved: pytorch#55800

For mobile use xnnpack implementation of hardswish

Test Plan: buck test //xplat/caffe2:pt_xnnpack_test

Differential Revision: D27712306

fbshipit-source-id: ac435539f11950c8a81900a7cce02d95b90f5cdf
axitkhurana added a commit to axitkhurana/pytorch that referenced this pull request Apr 27, 2021
Summary:
Pull Request resolved: pytorch#56714

Pull Request resolved: pytorch#55800

For mobile use xnnpack implementation of hardswish

Test Plan: buck test //xplat/caffe2:pt_xnnpack_test

Differential Revision: D27712306

fbshipit-source-id: 82fa5615f0437fd4f5898be7d96f7d8d74c00806
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 28fc59d.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Pull Request resolved: pytorch#56714

Pull Request resolved: pytorch#55800

For mobile use xnnpack implementation of hardswish

Test Plan: buck test //xplat/caffe2:pt_xnnpack_test

Reviewed By: kimishpatel

Differential Revision: D27712306

fbshipit-source-id: c7f0b70482aeef2aaa1966e2c669f79ecd29caa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants