Infer types for arguments of methods not invoked directly by monkeytype #57202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 7d826ba (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
nikithamalgifb
force-pushed
the
infer_types_methods
branch
2 times, most recently
from
e292056
to
4e4fd4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #57202 +/- ##
===========================================
+ Coverage 57.46% 77.68% +20.22%
===========================================
Files 596 1954 +1358
Lines 76343 194572 +118229
===========================================
+ Hits 43872 151160 +107288
- Misses 32471 43412 +10941 |
gmagogsfm
requested changes
Apr 29, 2021
nikithamalgifb
requested review from
albanD,
BowenBao,
ezyang,
H-Huang,
mingzhe09088,
mrshenli,
neginraoof,
pritamdamania87,
rohan-varma,
wayi1,
soulitzer,
spandantiwari and
zhaojuanmao
as code owners
nikithamalgifb
removed request for
ezyang,
albanD,
rohan-varma,
BowenBao,
pritamdamania87,
H-Huang and
neginraoof
nikithamalgifb
removed request for
spandantiwari,
mingzhe09088,
zhaojuanmao,
wayi1 and
soulitzer
nikithamalgifb
force-pushed
the
infer_types_methods
branch
from
e902c97
to
bfedd5b
Compare
added 5 commits
May 3, 2021 17:54
gmagogsfm
reviewed
May 6, 2021
| @@ -851,7 +851,8 @@ def call_prepare_scriptable_func(obj): | |||
| memo: Dict[int, torch.nn.Module] = {} | |||
| return call_prepare_scriptable_func_impl(obj, memo) | |||
|
|
|||
| def _script_pdt(obj, optimize=None, _frames_up=0, _rcb=None, example_inputs: Optional[List[Tuple]] = None): | |||
| def _script_pdt(obj, optimize=None, _frames_up=0, _rcb=None, | |||
| example_inputs: Union[List[Tuple], Dict[Callable, List[Tuple]], None] = None): | |||
There was a problem hiding this comment.
Created a task in asana for you about creating a docstring for _script_pdt since its usage is sort of complex now.
added 2 commits
May 10, 2021 09:23
added 5 commits
May 10, 2021 09:50
…r_types_methods
…r_types_methods
gmagogsfm
approved these changes
May 12, 2021
Comment on lines
+98
to
+99
| scripted_pdt_model = torch.jit._script_pdt(outer_pdt_model, example_inputs={inner_pdt_model: inner_input, | ||
| outer_pdt_model: outer_input, }) |
There was a problem hiding this comment.
inner_pdt_model: inner_input should not be needed here. Thus we should be able to pass in outer_input in simple format of List[Tuple]. Simple format input can be used in following few test cases as well.
|
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@nikithamalgifb merged this pull request in 9063cb0. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…pe (pytorch#57202) Summary: Support adding type annotations for class methods and nn.Module methods which are not invoked under the hood of MonkeyType ** Changes ** * This PR involves a slight change in how the example inputs are passed while scripting `class` and `nn.Module` objects. * The example inputs passed to `_script_pdt` is of the following format: - example_inputs= [(obj.method1, (arg_list)), (obj.method2, (arg_list)),] * For nn.Modules, to infer types for `forward` methods, example_inputs can be passed in two ways: - example_inputs= [(obj.forward, (arg_list, ))] - example_inputs = [(obj, (arg_list, ) )] Pull Request resolved: pytorch#57202 Reviewed By: desertfire Differential Revision: D28382827 Pulled By: nikithamalgifb fbshipit-source-id: 5481467f3e909493bf3f439ee312056943508534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding type annotations for class methods and nn.Module methods which are not invoked under the hood of MonkeyType
** Changes **
classandnn.Moduleobjects._script_pdtis of the following format:forwardmethods, example_inputs can be passed in two ways: