New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the error in conv1d example #57356
Conversation
💊 CI failures summary and remediationsAs of commit bb23606 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)
|
Job | Step | Action |
---|---|---|
clang-format | Run clang-format | 🔁 rerun |
🚧 1 fixed upstream failure:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict
branch (expand for instructions)
If your commit is older than viable/strict
, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- pytorch_macos_10_13_py3_test from Apr 29 until Apr 30 (54469e1 - 095c328)
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
@gchanan please help to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Just a minor formatting update and this is good to go.
torch/nn/functional.py
Outdated
@@ -62,8 +62,8 @@ | |||
|
|||
Examples:: | |||
|
|||
>>> filters = torch.randn(33, 16, 3) | |||
>>> inputs = torch.randn(20, 16, 50) | |||
>>> inputs = torch.randn(33,16,30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add back the proper spacing after the ,
please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD Thanks for reply,modification done
Hmm, I can not reproduce an error reported in #51225:
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Fixes pytorch#51225 Pull Request resolved: pytorch#57356 Reviewed By: albanD Differential Revision: D28173174 Pulled By: malfet fbshipit-source-id: 5e813306f2e2f7e0412ffaa5d147441134739e00
Summary: Fixes pytorch#51225 Pull Request resolved: pytorch#57356 Reviewed By: albanD Differential Revision: D28173174 Pulled By: malfet fbshipit-source-id: 5e813306f2e2f7e0412ffaa5d147441134739e00
Fixes #51225