Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fx quant: remove matching hack for binary qhandler #57470

Closed
wants to merge 1 commit into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented May 3, 2021

Stack from ghstack:

Summary:

Removes the earlier hack of matching patterns originally matched
to BinaryOpQuantizeHandler to switch to CopyHandler. After this PR,
each pattern can only be matched to one type of QuantizeHandler or
to nothing.

Test Plan:

python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D28152909

Summary:

Removes the earlier hack of matching patterns originally matched
to BinaryOpQuantizeHandler to switch to CopyHandler. After this PR,
each pattern can only be matched to one type of QuantizeHandler or
to nothing.

Test Plan:

```
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 3, 2021

💊 CI failures summary and remediations

As of commit d15116f (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 03 17:13:12 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in
May 03 17:13:12     #7 0x555afb6dc51b in PyEval_EvalCode /tmp/build/80754af9/python_1614113050744/work/Python/ceval.c:731
May 03 17:13:12     #8 0x555afb75c5e3 in run_mod /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:1025
May 03 17:13:12     #9 0x555afb75c67c in PyRun_StringFlags /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:949
May 03 17:13:12     #10 0x555afb75c6de in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:445
May 03 17:13:12     #11 0x555afb7604e2 in run_command /tmp/build/80754af9/python_1614113050744/work/Modules/main.c:301
May 03 17:13:12     #12 0x555afb7604e2 in Py_Main /tmp/build/80754af9/python_1614113050744/work/Modules/main.c:749
May 03 17:13:12     #13 0x555afb62ab0d in main /tmp/build/80754af9/python_1614113050744/work/Programs/python.c:69
May 03 17:13:12     #14 0x7f48d99c283f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291
May 03 17:13:12     #15 0x555afb709d6f in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103
May 03 17:13:12 
May 03 17:13:12 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
May 03 17:13:12 + retcode=1
May 03 17:13:12 + set -e
May 03 17:13:12 + return 1
May 03 17:13:12 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]]
May 03 17:13:12 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]]
May 03 17:13:12 + IN_PULL_REQUEST=https://github.com/pytorch/pytorch/pull/57470
May 03 17:13:12 + '[' -n https://github.com/pytorch/pytorch/pull/57470 ']'
May 03 17:13:12 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]]
May 03 17:13:12 ++ mktemp
May 03 17:13:12 + DETERMINE_FROM=/tmp/tmp.YfsHBRhZ99

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test1

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

vkuzo added a commit that referenced this pull request May 3, 2021
Summary:

Removes the earlier hack of matching patterns originally matched
to BinaryOpQuantizeHandler to switch to CopyHandler. After this PR,
each pattern can only be matched to one type of QuantizeHandler or
to nothing.

Test Plan:

```
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 24920cd7f19af253e0b6adbc2855edff373afbf9
Pull Request resolved: #57470
@vkuzo vkuzo requested review from jerryzh168 and HDCharles May 3, 2021 16:31
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7c3a30f.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/337/head branch May 8, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Pull Request resolved: pytorch#57470

Removes the earlier hack of matching patterns originally matched
to BinaryOpQuantizeHandler to switch to CopyHandler. After this PR,
each pattern can only be matched to one type of QuantizeHandler or
to nothing.

Test Plan:
```
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
```

Imported from OSS

Reviewed By: jerryzh168

Differential Revision: D28152909

fbshipit-source-id: afc285e770bd7eb0518c90e3ee4874c421e78bbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants