New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split TestAsserts by functionality #58919
Conversation
Instead of having one large `TestAsserts` test case, we split of tests for self-contained functionality like container or complex checking into separate test cases. That makes it a lot easier to keep an overview over what is tested. [ghstack-poisoned]
Instead of having one large `TestAsserts` test case, we split of tests for self-contained functionality like container or complex checking into separate test cases. That makes it a lot easier to keep an overview over what is tested. ghstack-source-id: f93caedb2d4cb044447362c0ed6f27657ca52780 Pull Request resolved: #58919
💊 CI failures summary and remediationsAs of commit 00783ac (more details on the Dr. CI page and at hud.pytorch.org/pr/58919): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Seems fine; let's just get the previous PR fixed |
Instead of having one large `TestAsserts` test case, we split of tests for self-contained functionality like container or complex checking into separate test cases. That makes it a lot easier to keep an overview over what is tested. [ghstack-poisoned]
Instead of having one large TestAsserts test case, we split of tests for self-contained functionality like container or complex checking into separate test cases. That makes it a lot easier to keep an overview over what is tested. [ghstack-poisoned]
Instead of having one large TestAsserts test case, we split of tests for self-contained functionality like container or complex checking into separate test cases. That makes it a lot easier to keep an overview over what is tested. [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Stack from ghstack:
msg
intorch.testing.assert_close
#60254 tests for diagnostics in callablemsg
intorch.testing.assert_close
torch.testing.assert_close
#60163 update docstring examples oftorch.testing.assert_close
torch.testing.assert_close
in case of mismatching values #60091 Improve error messages oftorch.testing.assert_close
in case of mismatching valuestorch.testing.assert_close
#58918 make assert_equal an example how to partialtorch.testing.assert_close
Instead of having one large TestAsserts test case, we split of tests for
self-contained functionality like container or complex checking into
separate test cases. That makes it a lot easier to keep an overview over
what is tested.
Differential Revision: D29259407