Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release/1.9] Link whole CuDNN for CUDA-11.1 #59873

Merged
merged 4 commits into from
Jun 11, 2021
Merged

[Release/1.9] Link whole CuDNN for CUDA-11.1 #59873

merged 4 commits into from
Jun 11, 2021

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 11, 2021 •
edited

Fixes #50153

@malfet
Move cublas dependency after CuDNN (pytorch#58287)
5b987f1 
Summary:
Library linking order matters during static linking
Not sure whether its a bug or a feature, but if cublas is reference
before CuDNN, it will be partially statically linked into the library,
even if it is not used

Pull Request resolved: pytorch#58287

Reviewed By: janeyx99

Differential Revision: D28433165

Pulled By: malfet

fbshipit-source-id: 8dffa0533075126dc383428f838f7d048074205c
@malfet
[CMake] Split caffe2::cudnn into public and private (pytorch#59721)
f4f5487 
Summary:
This is only important for builds where cuDNN is linked statically into libtorch_cpu.
Before this PR PyTorch wheels often accidentally contained several partial copies of cudnn_static library.
Splitting the interface into header only (cudnn-public) and library+headers(cudnn-private) prevents those from happening.
Preliminary step towards enabling optional linking whole cudnn_library to workaround issue reported in pytorch#50153

Pull Request resolved: pytorch#59721

Reviewed By: ngimel

Differential Revision: D29000967

Pulled By: malfet

fbshipit-source-id: f054df92b265e9494076ab16c247427b39da9336
@malfet
Add USE_WHOLE_CUDNN option (pytorch#59744)
6dc44ca 
Summary:
It is only enabled if USE_STATIC_CUDNN is enabled

Next step after pytorch#59721 towards resolving fast kernels stripping reported in pytorch#50153

Pull Request resolved: pytorch#59744

Reviewed By: seemethere, ngimel

Differential Revision: D29007314

Pulled By: malfet

fbshipit-source-id: 7091e299c0c6cc2a8aa82fbf49312cecf3bb861a
@malfet
[Binary] Link whole CuDNN for CUDA-11.1 (pytorch#59802)
1dbc201 
Summary:
Fixes pytorch#50153

Pull Request resolved: pytorch#59802

Reviewed By: driazati, seemethere

Differential Revision: D29033537

Pulled By: malfet

fbshipit-source-id: e816fc71f273ae0b4ba8a0621d5368a2078561a1
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2021 •
edited

💊 CI failures summary and remediations

As of commit 1dbc201 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet changed the title malfet/link cudnn whole 1.9 [Release/1.9] Link whole CuDNN for CUDA-11.1 Jun 11, 2021
@malfet malfet requested a review from a team June 11, 2021 15:40
@malfet malfet mentioned this pull request Jun 11, 2021
Closed
@malfet malfet merged commit 90e6773 into pytorch:release/1.9 Jun 11, 2021
@malfet malfet deleted the malfet/link-cudnn-whole-1.9 branch June 11, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@walterddr walterddr walterddr approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malfet @facebook-github-bot @seemethere @walterddr