Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignoring Tensor properties in torch.overrides #60050

Closed
wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jun 15, 2021

Stack from ghstack:

It doesn't work to put torch.Tensor.prop.get in the ignored
list. Now it does. (Not exercised here, see next diff in stack).

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D29171464

It doesn't work to put torch.Tensor.prop.__get__ in the ignored
list.  Now it does.  (Not exercised here, see next diff in stack).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 15, 2021

💊 CI failures summary and remediations

As of commit 524b985 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 16 19:46:14 AssertionError: False is not tr...lowed difference with rtol=0 and atol=0 is only 0!
Jun 16 19:46:14   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 516, in run_test
Jun 16 19:46:14     getattr(self, test_name)()
Jun 16 19:46:14   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 400, in wrapper
Jun 16 19:46:14     fn()
Jun 16 19:46:14   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/distributed_test.py", line 4591, in test_ddp_logging_data_cpu
Jun 16 19:46:14     self.assertEqual(ddp_logging_data.get("find_unused_parameters"), 0)
Jun 16 19:46:14   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1419, in assertEqual
Jun 16 19:46:14     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
Jun 16 19:46:14   File "/opt/conda/lib/python3.6/unittest/case.py", line 682, in assertTrue
Jun 16 19:46:14     raise self.failureException(msg)
Jun 16 19:46:14 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 1 and 0 gives a difference of 1, but the allowed difference with rtol=0 and atol=0 is only 0!
Jun 16 19:46:14 
Jun 16 19:46:14 
Jun 16 19:46:14 
Jun 16 19:46:14 ----------------------------------------------------------------------
Jun 16 19:46:14 Ran 220 tests in 59.249s
Jun 16 19:46:14 
Jun 16 19:46:14 FAILED (errors=1, skipped=110)
Jun 16 19:46:14 
Jun 16 19:46:14 Generating XML reports...
Jun 16 19:46:14 Generated XML report: test-reports/dist-gloo/distributed.test_distributed_fork/TEST-TestDistBackendWithFork-20210616194514.xml

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It doesn't work to put torch.Tensor.prop.__get__ in the ignored
list.  Now it does.  (Not exercised here, see next diff in stack).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Jun 16, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 1f50dc6.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1040/head branch June 25, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants