New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignoring Tensor properties in torch.overrides #60050
Conversation
It doesn't work to put torch.Tensor.prop.__get__ in the ignored list. Now it does. (Not exercised here, see next diff in stack). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 524b985 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It doesn't work to put torch.Tensor.prop.__get__ in the ignored list. Now it does. (Not exercised here, see next diff in stack). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Stack from ghstack:
It doesn't work to put torch.Tensor.prop.get in the ignored
list. Now it does. (Not exercised here, see next diff in stack).
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D29171464