New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer linalg::qr over qr in the C++ API #60529
Conversation
💊 CI failures summary and remediationsAs of commit 7b85943 (more details on the Dr. CI page and at hud.pytorch.org/pr/60529):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_macos_10_13_py3_test (1/1)Step: "Test" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks @lezcano!
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ping @mruberry |
Fixes #60060
Also adds
torch::linalg::qr
to the C++ API, as it was missing.