Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer linalg::qr over qr in the C++ API #60529

Closed
wants to merge 1 commit into from

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented Jun 23, 2021

Fixes #60060

Also adds torch::linalg::qr to the C++ API, as it was missing.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2021

💊 CI failures summary and remediations

As of commit 7b85943 (more details on the Dr. CI page and at hud.pytorch.org/pr/60529):


  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)
  • 1/3 broken upstream at merge base 90cd57e from Jun 22 until Jun 23

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 23 12:10:42 RuntimeError: test_quantization failed!
Jun 23 12:10:42 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQNNPackOps-20210623120743.xml
Jun 23 12:10:42 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFx-20210623120743.xml
Jun 23 12:10:42 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFxOps-20210623120743.xml
Jun 23 12:10:42 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.eager.test_quantize_eager_ptq.TestQuantizeONNXExport-20210623120743.xml
Jun 23 12:10:42 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQuantizedEmbeddingOps-20210623120743.xml
Jun 23 12:10:42 Traceback (most recent call last):
Jun 23 12:10:42   File "test/run_test.py", line 1313, in <module>
Jun 23 12:10:42     main()
Jun 23 12:10:42   File "test/run_test.py", line 1292, in main
Jun 23 12:10:42     raise RuntimeError(err_message)
Jun 23 12:10:42 RuntimeError: test_quantization failed!
Jun 23 12:10:42 + cleanup
Jun 23 12:10:42 + retcode=1
Jun 23 12:10:42 + set +x


Exited with code exit status 1


🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@lezcano lezcano added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Jun 23, 2021
@lezcano lezcano changed the title Deprecate linalg C++ API Prever linalg::qr over qr in the C++ API Jun 23, 2021
@lezcano lezcano changed the title Prever linalg::qr over qr in the C++ API Prefer linalg::qr over qr in the C++ API Jun 23, 2021
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @lezcano!

@facebook-github-bot
Copy link
Contributor

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano
Copy link
Collaborator Author

lezcano commented Jun 28, 2021

ping @mruberry

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in af5a0df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning with torch::nn::init::orthogonal_ with LibTorch 1.9.0
4 participants