ENH Adds no_batch_dim support for pad 2d and 3d #62183
Conversation
thomasjpfan
added
module: nn
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b61ed60 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
| input_inner = input.unsqueeze(0); | ||
| output_inner = output.unsqueeze(0); |
There was a problem hiding this comment.
This is a bug fix where the no_batch_dim test serves as a non-regression test.
There was a problem hiding this comment.
Just to clarify, the bug kept non-batch mode from functioning properly?
There was a problem hiding this comment.
Just to clarify, the bug kept non-batch mode from functioning properly?
Yup. In this case, "non-batch mode" == "no batch dims". Now that we have better language for batch dims, I would want to renamed the batch_mode to has_batch_dim.
| input_ = input.unsqueeze(0); | ||
| output_ = output.unsqueeze(0); |
| input_inner = input.unsqueeze(0); | ||
| output_inner = output.unsqueeze(0); |
There was a problem hiding this comment.
Just to clarify, the bug kept non-batch mode from functioning properly?
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@jbschlosser merged this pull request in 7c588d5. |
Towards #60585