Are tensors on same device? #62653
Closed
Are tensors on same device? #62653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 858c752 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
d6107e7
to
a1d3603
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
a1d3603
to
5ad598f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
5ad598f
to
7563b78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
7563b78
to
2871296
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
2871296
to
65fe0b1
Compare
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
65fe0b1
to
1e08211
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
1e08211
to
4c29dd2
Compare
r-barnes
added a commit
to r-barnes/FBGEMM
that referenced
this pull request
Oct 11, 2021
Summary: Pull Request resolved: pytorch/pytorch#62653 This consolidates checks determining whether tensors live on the same device into a single line using template parameter packs to unroll the check code. The advantage of using the new checking syntax is that it makes it easy to use static analysis to determine both if the check is present and whether or not it is comprehensive. D30072495 includes a linter which performs this action. Note that this is especially useful for PyTorch extensions which don't receive this check automatically from codegen. Reviewed By: ngimel Differential Revision: D29924464 fbshipit-source-id: 18110f07f5b2dba9d231f767cfb0532849255bc7
r-barnes
force-pushed
the
export-D29924464
branch
from
4c29dd2
to
f77f1f1
Compare
r-barnes
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
added a commit
to r-barnes/FBGEMM
that referenced
this pull request
Oct 11, 2021
Summary: Pull Request resolved: pytorch#728 Pull Request resolved: pytorch/pytorch#62653 This consolidates checks determining whether tensors live on the same device into a single line using template parameter packs to unroll the check code. The advantage of using the new checking syntax is that it makes it easy to use static analysis to determine both if the check is present and whether or not it is comprehensive. D30072495 includes a linter which performs this action. Note that this is especially useful for PyTorch extensions which don't receive this check automatically from codegen. Reviewed By: ngimel Differential Revision: D29924464 fbshipit-source-id: dd2bc7f163366ca43e8eb00da0227e9ef972c636
Summary: Pull Request resolved: pytorch/FBGEMM#728 Pull Request resolved: pytorch#62653 This consolidates checks determining whether tensors live on the same device into a single line using template parameter packs to unroll the check code. The advantage of using the new checking syntax is that it makes it easy to use static analysis to determine both if the check is present and whether or not it is comprehensive. D30072495 includes a linter which performs this action. Note that this is especially useful for PyTorch extensions which don't receive this check automatically from codegen. Test Plan: ``` buck test //caffe2/torch/fb/sparsenn:gpu_test buck test //caffe2/torch/fb/sparsenn:test ``` Reviewed By: ngimel Differential Revision: D29924464 fbshipit-source-id: 6c575dda8b707eb6df7e9675d2bb62ec8e541753
|
This pull request was exported from Phabricator. Differential Revision: D29924464 |
r-barnes
force-pushed
the
export-D29924464
branch
from
f77f1f1
to
858c752
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This consolidates checks determining whether tensors live on the same device into a single line using template parameter packs to unroll the check code.
The advantage of using the new checking syntax is that it makes it easy to use static analysis to determine both if the check is present and whether or not it is comprehensive. D30072495 includes a linter which performs this action.
Note that this is especially useful for PyTorch extensions which don't receive this check automatically from codegen.
Test Plan:
Differential Revision: D29924464