New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpInfo] Added ReductionOpInfo subclass of OpInfo and ported sum test #62737
[OpInfo] Added ReductionOpInfo subclass of OpInfo and ported sum test #62737
Conversation
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e0c2b92 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ghstack-source-id: 5397cec2dd605ef9a704ce7a28d57652bf808286 Pull Request resolved: #62737
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ghstack-source-id: 516cf6b5604baf97531f3c6d9f2680857281cfec Pull Request resolved: #62737
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions inline for you to consider, but overall things look good. Hurray ReductionInfos!
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 [ghstack-poisoned]
ghstack-source-id: 1c14fed3be56051f19a7c5b28eaf0a03bf563b0b Pull Request resolved: #62737
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@heitorschueroff merged this pull request in 774ae08. |
Stack from ghstack:
ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as
max
andmin
that return multiple tensors andquantile
that can return multiple values.fixes #49746
Differential Revision: D30406568