Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add cross references to torch.transpose and torch.t #63177

Closed

Conversation

SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Aug 12, 2021

Stack from ghstack:

Summary
This commit adds a link in the documentation for torch.transpose that
directs to torch.t and vice versa. These two functions are related and
it is useful for users of one to know about the other.

Test Plan
Continuous integration.

Fixes
This commit fixes #56267.

Differential Revision: D30292654

**Summary**
This commit adds a link in the documentation for `torch.transpose` that
directs to `torch.t` and vice versa. These two functions are related and
it is useful for users of one to know about the other.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #56267.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9666c6c (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test1 Set Up CI Environment After attach_workspace 🔁 rerun

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…h.t`"

**Summary**
This commit adds a link in the documentation for `torch.transpose` that
directs to `torch.t` and vice versa. These two functions are related and
it is useful for users of one to know about the other.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #56267.

[ghstack-poisoned]
SplitInfinity pushed a commit that referenced this pull request Aug 12, 2021
**Summary**
This commit adds a link in the documentation for `torch.transpose` that
directs to `torch.t` and vice versa. These two functions are related and
it is useful for users of one to know about the other.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #56267.

ghstack-source-id: d144b9cd7fbc015d2296fc76cee1869daa69fb14
Pull Request resolved: #63177
@SplitInfinity
Copy link
Author

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in 548fe68.

@@ -9350,6 +9350,8 @@ def merge_dicts(*dicts):
tensor([[ 0.4875, 0.3938],
[ 0.9158, -0.6929],
[-0.5872, 0.6932]])

See also :func:`torch.transpose`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have "seealso" sections for this that appear before args. See https://pytorch.org/docs/master/generated/torch.linalg.svd.html?highlight=linalg%20svd#torch.linalg.svd for an example how do this. I would move both of these sentences into those sections for clarity + consistency.

alanwaketan pushed a commit that referenced this pull request Aug 17, 2021
Summary:
Pull Request resolved: #63177

**Summary**
This commit adds a link in the documentation for `torch.transpose` that
directs to `torch.t` and vice versa. These two functions are related and
it is useful for users of one to know about the other.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #56267.

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D30292654

Pulled By: SplitInfinity

fbshipit-source-id: 8e60cd7a598ff8b4756cb30141399dfe8e118338
@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/159/head branch August 17, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants