[JIT][WIP] memorization memory planning #63873
Closed
+426
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Aug 24, 2021
facebook-github-bot
added
the
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 20114a8 (more details on the Dr. CI page):
🕵️ 19 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Lint / clang-format |
Run clang-format | 🔁 rerun |
 pytorch_xla_linux_bionic_py3_6_clang9_build |
Build | 🔁 rerun |
| pytorch_linux_xenial_py3_6_gcc5_4_build |
Build | 🔁 rerun |
ci.pytorch.org: 1 failed
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Aug 24, 2021
[ghstack-poisoned]
[ghstack-poisoned]
makslevental
pushed a commit
that referenced
this pull request
Aug 24, 2021
ghstack-source-id: 67d22a0884a989ae76169025879d8c8c50099ad7 Pull Request resolved: #63873
[ghstack-poisoned]
makslevental
pushed a commit
that referenced
this pull request
Aug 24, 2021
ghstack-source-id: 14e2f8ef811c0f24a617cf609218a10a3306aec4 Pull Request resolved: #63873
[ghstack-poisoned]
This was referenced Sep 1, 2021
Closed
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
makslevental
pushed a commit
that referenced
this pull request
Sep 13, 2021
ghstack-source-id: 5256d94abbf80ddda00980dade0623674bb05299 Pull Request resolved: #63873 reorder refactor profiling allocator put profiling back reconcile profiling ghstack-source-id: 5256d94abbf80ddda00980dade0623674bb05299 Pull Request resolved: #64351 use make_pair instead of make_tuple incorporate uniqueliverange fix tests whoops rename stuff size_t for memory tracing
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
makslevental
added a commit
that referenced
this pull request
Sep 21, 2021
ghstack-source-id: 132dc0c37f92f5ad0c855da06adc6a41f82f6574 Pull Request resolved: #63873 reorder refactor profiling allocator put profiling back reconcile profiling ghstack-source-id: 132dc0c37f92f5ad0c855da06adc6a41f82f6574 Pull Request resolved: #64351 use make_pair instead of make_tuple incorporate uniqueliverange fix tests whoops rename stuff size_t for memory tracing
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
makslevental
added a commit
that referenced
this pull request
Sep 21, 2021
ghstack-source-id: b038aa015025f59110466e1326512379c97b9427 Pull Request resolved: #63873 reorder refactor profiling allocator put profiling back reconcile profiling ghstack-source-id: b038aa015025f59110466e1326512379c97b9427 Pull Request resolved: #64351 use make_pair instead of make_tuple incorporate uniqueliverange fix tests whoops rename stuff size_t for memory tracing
makslevental
changed the title
This PR extends memory planning strategies to support memory allocations and frees collected using the `MemoryTracingAllocator` (which follows the pattern from kineto). These plans can then be deployed using `MemoryPlanningAllocator` in combination with `prim::PreAllocateTensor` ops (inserted into the graph) to appropriately give out slices of the initially allocated region. Differential Revision: [D30769097](https://our.internmc.facebook.com/intern/diff/D30769097) [ghstack-poisoned]
makslevental
added a commit
that referenced
this pull request
Nov 3, 2021
ghstack-source-id: db94a55a0dd8eabf662ea9ae260ffb62f1c8bdb6 Pull Request resolved: #63873 reorder refactor profiling allocator put profiling back reconcile profiling ghstack-source-id: db94a55a0dd8eabf662ea9ae260ffb62f1c8bdb6 Pull Request resolved: #64351 use make_pair instead of make_tuple incorporate uniqueliverange fix tests whoops rename stuff size_t for memory tracing
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
|
@makslevental has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Hi @makslevental! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR extends memory planning strategies to support memory allocations and frees collected using the
MemoryTracingAllocator(which follows the pattern from kineto). These plans can then be deployed usingMemoryPlanningAllocatorin combination withprim::PreAllocateTensorops (inserted into the graph) to appropriately give out slices of the initially allocated region.Differential Revision: D30769097