Fix attr_to_scope's key in `torch/utils/tensorboard/_pytorch_graph.py` #65692

liulixinkerry · 2021-09-27T13:58:10Z

facebook-github-bot · 2021-09-27T13:58:14Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2021-09-27T13:58:16Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/65692
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 70b7562 (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 broken upstream at merge base facff2e from Sep 25 until Sep 26

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py
Auto-merging .circleci/cimodel/data/binary_build_data.py
CONFLICT (add/add): Merge conflict in .azure_pipelines/job_templates/set-environment-variables.yml
Auto-merging .azure_pipelines/job_templates/set-environment-variables.yml
CONFLICT (add/add): Merge conflict in .azure_pipelines/job_templates/prepare-build-template.yml
Auto-merging .azure_pipelines/job_templates/prepare-build-template.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py
Auto-merging .circleci/cimodel/data/binary_build_data.py
CONFLICT (add/add): Merge conflict in .azure_pipelines/job_templates/set-environment-variables.yml
Auto-merging .azure_pipelines/job_templates/set-environment-variables.yml
CONFLICT (add/add): Merge conflict in .azure_pipelines/job_templates/prepare-build-template.yml
Auto-merging .azure_pipelines/job_templates/prepare-build-template.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

1 job timed out:

pytorch_linux_xenial_py3_clang7_asan_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_linux_xenial_py3_clang7_asan_test1 from Sep 25 until Sep 26 (cd80bbe - facff2e)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2021-09-27T14:39:39Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot · 2021-09-27T16:39:55Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot · 2021-09-27T20:36:24Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

pytorch-probot · 2021-10-04T07:27:11Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/liulixinkerry/pytorch/blob/70b75628f39ccf8a05be8bd6f35cc50a9747e00e/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/xla`	✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/win`	✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
win-vs2019-cuda10.2-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/win`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

liulixinkerry · 2021-10-04T07:30:52Z

Dear @edward-io ,
Sorry to interrupt you. I just wonder whether it is possible to merge this pull request. It will be very helpful since I can use the fixed tensorboard to parse the ONNX graph correctly. Hope for your understanding.

edward-io · 2021-10-04T21:10:58Z

@liulixinkerry thank you for your contribution! Can you add a test to go along with this change?

liulixinkerry · 2021-10-06T11:05:44Z

Dear @edward-io ,
I have added the test. May you take a look? If there is any need, please don't hesitate to contact me.

facebook-github-bot · 2021-10-15T05:19:50Z

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

edward-io

@liulixinkerry Thank you for the thorough test and investigation! Apologies for not responding earlier, I was on vacation for a few days last week and I'm catching up on things now. Just some small areas to address, but otherwise looks good!

torch/utils/tensorboard/_pytorch_graph.py

test/test_tensorboard.py

facebook-github-bot · 2021-10-16T05:28:05Z

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

edward-io · 2021-10-16T05:29:17Z

@liulixinkerry looks great, I'll merge this in on Monday. Thanks for your contributions in making PyTorch better!

facebook-github-bot · 2021-10-20T21:36:48Z

@edward-io merged this pull request in 2572399.

use id instead of name as key

25a1d2e

pytorchbot added the open source label Sep 27, 2021

facebook-github-bot added the cla signed label Sep 27, 2021

gchanan requested a review from edward-io September 27, 2021 23:38

gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 27, 2021

liulixinkerry closed this Oct 4, 2021

liulixinkerry deleted the fix_attr_to_scope_key branch October 4, 2021 07:27

liulixinkerry restored the fix_attr_to_scope_key branch October 4, 2021 07:27

liulixinkerry reopened this Oct 4, 2021

liulixinkerry closed this Oct 4, 2021

liulixinkerry deleted the fix_attr_to_scope_key branch October 4, 2021 07:27

pytorch-probot bot added the ciflow/default label Oct 4, 2021

liulixinkerry restored the fix_attr_to_scope_key branch October 4, 2021 07:27

liulixinkerry reopened this Oct 4, 2021

liulixinkerry added 2 commits October 6, 2021 11:08

add unit test

fe00d2d

formatting

bac2942

edward-io reviewed Oct 15, 2021

View reviewed changes

torch/utils/tensorboard/_pytorch_graph.py Outdated Show resolved Hide resolved

test/test_tensorboard.py Outdated Show resolved Hide resolved

use debugName as key and python init

70b7562

facebook-github-bot closed this in 2572399 Oct 20, 2021

facebook-github-bot added the Merged label Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix attr_to_scope's key in `torch/utils/tensorboard/_pytorch_graph.py` #65692

Fix attr_to_scope's key in `torch/utils/tensorboard/_pytorch_graph.py` #65692

liulixinkerry commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021 •

edited

facebook-github-bot commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

pytorch-probot bot commented Oct 4, 2021 •

edited

⚛️ CI Flow

liulixinkerry commented Oct 4, 2021

edward-io commented Oct 4, 2021

liulixinkerry commented Oct 6, 2021

facebook-github-bot commented Oct 15, 2021

edward-io left a comment

facebook-github-bot commented Oct 16, 2021

edward-io commented Oct 16, 2021

facebook-github-bot commented Oct 20, 2021

Fix attr_to_scope's key in torch/utils/tensorboard/_pytorch_graph.py #65692

Fix attr_to_scope's key in torch/utils/tensorboard/_pytorch_graph.py #65692

Conversation

liulixinkerry commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

Action Required

Process

facebook-github-bot commented Sep 27, 2021 • edited

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

🚧 1 fixed upstream failure:

facebook-github-bot commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

facebook-github-bot commented Sep 27, 2021

pytorch-probot bot commented Oct 4, 2021 • edited

⚛️ CI Flow

liulixinkerry commented Oct 4, 2021

edward-io commented Oct 4, 2021

liulixinkerry commented Oct 6, 2021

facebook-github-bot commented Oct 15, 2021

edward-io left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Oct 16, 2021

edward-io commented Oct 16, 2021

facebook-github-bot commented Oct 20, 2021

Fix attr_to_scope's key in `torch/utils/tensorboard/_pytorch_graph.py` #65692

Fix attr_to_scope's key in `torch/utils/tensorboard/_pytorch_graph.py` #65692

facebook-github-bot commented Sep 27, 2021 •

edited

pytorch-probot bot commented Oct 4, 2021 •

edited