Sparse CSR CUDA: fix input checks for addmm and mm
#66485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7949f07 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Oct 12, 2021
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 12, 2021
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. ghstack-source-id: ba2b4efb1e9f092c897da0484caa8631fccc527a Pull Request resolved: pytorch#66485
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 12, 2021
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. ghstack-source-id: af6563cba012fc9eac3206f00037b731eefdd85e Pull Request resolved: pytorch#66485
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 13, 2021
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. ghstack-source-id: 8a32a9597e02bc05b1ac15752407e30a48381a69 Pull Request resolved: pytorch#66485
cpuhrsch
reviewed
Oct 18, 2021
| const Scalar& beta, | ||
| const Scalar& alpha, | ||
| Tensor& result) { | ||
| TORCH_INTERNAL_ASSERT_DEBUG_ONLY(mat1.is_sparse_csr()); |
There was a problem hiding this comment.
As mentioned in #63583 TORCH_INTERNAL_ASSERT_DEBUG_ONLY doesn't run in CI or in the binaries we distribute. It might make sense to use a regular internal assert or explicitly throw an error if this condition isn't met.
There was a problem hiding this comment.
TORCH_INTERNAL_ASSERT_DEBUG_ONLY is not something that should be tested usually. It could be all removed and nothing would change. It's just my style of warning some potential future developer (who surely develops with DEBUG=1) that this function is intended to be used only when mat1 is sparse csr matrix.
I'd rather remove the assert completely, or replace it with a comment, than turning into a regular assert that 100% of the time in the current code evaluates to assert(true);. It could be expensive to check is_sparse_csr, we never know without measuring!
cpuhrsch
approved these changes
Oct 18, 2021
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 19, 2021
The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. ghstack-source-id: bcdc7fc80b4c1fbb1cc43f4746d5e8b6f43d2e68 Pull Request resolved: pytorch#66485
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
Summary: Pull Request resolved: #66485 The errors for incorrectly sized inputs should match the dense variants of functions. Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and removed unnecessary device check. cc nikitaved pearu cpuhrsch IvanYashchuk Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D31764036 Pulled By: cpuhrsch fbshipit-source-id: 76900fe9e4a49474695a01f34bad41cb3422321c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
triangular_solve_out#62180torch.addmm#65606torch.addwith all inputs sparse #64391addmv_out#61536triangular_solve_out#61858torch.addwith all inputs sparse #63948torch.addmmwith all inputs sparse #63511addmmandmm#66485The errors for incorrectly sized inputs should match the dense variants
of functions.
Moved addmm_out_sparse_csr_dense_cuda from SparseCsrTensorMath.cu and
removed unnecessary device check.
cc @nikitaved @pearu @cpuhrsch @IvanYashchuk
Differential Revision: D31764036