Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Change from unique_ptr to optional for RecordFunction state #68397

Closed
wants to merge 5 commits into from
Closed

[PyTorch] Change from unique_ptr to optional for RecordFunction state #68397

wants to merge 5 commits into from

Commits on Nov 16, 2021

  1. [PyTorch] Change from unique_ptr to optional for RecordFunction state 

    Now that hot paths can avoid instantiating RecordFunction by using shouldRunRecordFunction, we can improve efficiency for profiling cases by avoiding a large heap allocation.

Differential Revision: [D32448365](https://our.internmc.facebook.com/intern/diff/D32448365/)

[ghstack-poisoned]
    @swolchok
    swolchok committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    a80b239 View commit details
    Browse the repository at this point in the history

  2. Update on "[PyTorch] Change from unique_ptr to optional for RecordFun… 

    …ction state"

Now that hot paths can avoid instantiating RecordFunction by using shouldRunRecordFunction, we can improve efficiency for profiling cases by avoiding a large heap allocation.

Differential Revision: [D32448365](https://our.internmc.facebook.com/intern/diff/D32448365/)

[ghstack-poisoned]
    @swolchok
    swolchok committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    ba23b03 View commit details
    Browse the repository at this point in the history

  3. Update on "[PyTorch] Change from unique_ptr to optional for RecordFun… 

    …ction state"

Now that hot paths can avoid instantiating RecordFunction by using shouldRunRecordFunction, we can improve efficiency for profiling cases by avoiding a large heap allocation.

Differential Revision: [D32448365](https://our.internmc.facebook.com/intern/diff/D32448365/)

[ghstack-poisoned]
    @swolchok
    swolchok committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    dbe13d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Update on "[PyTorch] Change from unique_ptr to optional for RecordFun… 

    …ction state"

Now that hot paths can avoid instantiating RecordFunction by using shouldRunRecordFunction, we can improve efficiency for profiling cases by avoiding a large heap allocation.

Differential Revision: [D32448365](https://our.internmc.facebook.com/intern/diff/D32448365/)

[ghstack-poisoned]
    @swolchok
    swolchok committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    221ff56 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Update on "[PyTorch] Change from unique_ptr to optional for RecordFun… 

    …ction state"

Now that hot paths can avoid instantiating RecordFunction by using shouldRunRecordFunction, we can improve efficiency for profiling cases by avoiding a large heap allocation.

Differential Revision: [D32448365](https://our.internmc.facebook.com/intern/diff/D32448365/)

[ghstack-poisoned]
    @swolchok
    swolchok committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    b236dc0 View commit details
    Browse the repository at this point in the history