make meta tensor data access error message for expressive in assert_close #68802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ddd15f2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
pmeier
added
module: meta tensors
module: testing
Until #68592 is resolved, we explicitly exclude them to have an expressive error message. [ghstack-poisoned]
Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
[ghstack-poisoned]
This was referenced Dec 10, 2021
Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
mruberry
reviewed
Dec 15, 2021
Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
pmeier
changed the title
…in assert_close" Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
…in assert_close" Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
…in assert_close" Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
…in assert_close" Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
…in assert_close" Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) NotImplementedError: Could not run 'aten::abs.out' with arguments from the 'Meta' backend. [...] [...] The above exception was the direct cause of the following exception: [...] RuntimeError: Comparing TensorLikePair( id=(), actual=tensor(..., device='meta', size=()), expected=tensor(..., device='meta', size=()), rtol=1.3e-06, atol=1e-05, equal_nan=False, check_device=True, check_dtype=True, check_layout=True, check_stride=False, check_is_coalesced=True, ) resulted in the unexpected exception above. If you are a user and see this message during normal operation please file an issue at https://github.com/pytorch/pytorch/issues. If you are a developer and working on the comparison functions, please except the previous error and raise an expressive `ErrorMeta` instead. ``` Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved: ```python >>> t = torch.empty((), device="meta") >>> assert_close(t, t) ValueError: Comparing meta tensors is currently not supported ``` [ghstack-poisoned]
mruberry
reviewed
Jan 12, 2022
| try: | ||
| yield | ||
| except NotImplementedError as error: | ||
| if "meta" not in str(error).lower(): |
There was a problem hiding this comment.
I'm not in love with this mechanism for detecting if the not impl error is based on the tensor being a meta tensor or not, but it seems OK for now
There was a problem hiding this comment.
Me neither. But I don't think there is a better option right now. We should remove this while resolving #68592.
mruberry
approved these changes
Jan 12, 2022
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.testing.assert_equalinTestCase.assertEqual#67796Without this patch, the error message of comparing meta tensors looks like this after #68722 was merged:
Thus, we follow our own advice and turn it into an expected exception until #68592 is resolved:
Differential Revision: D33542999