FX: ensure node stack trace survives copying #69368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 594409c (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vkuzo
added a commit
that referenced
this pull request
Dec 3, 2021
Summary: Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 0a077d9068f4d0917e50495a2256a1bea372b590 Pull Request resolved: #69368
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jamesr66a
approved these changes
Dec 3, 2021
torch/fx/graph.py
Outdated
| @@ -747,6 +747,7 @@ def node_copy(self, node: Node, arg_transform: Callable[[Node], 'Argument'] = la | |||
| assert isinstance(kwargs, dict) | |||
| result_node = self.create_node(node.op, node.target, args, kwargs, node.name, node.type) | |||
| result_node.meta = copy.copy(node.meta) | |||
| result_node.stack_trace = copy.copy(node.stack_trace) | |||
There was a problem hiding this comment.
Can we move the stack trace into meta instead?
Summary: Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D32835248](https://our.internmc.facebook.com/intern/diff/D32835248) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D32835248](https://our.internmc.facebook.com/intern/diff/D32835248) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 6, 2021
Summary: Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 63be485a56141ebccd278d89214553555bbe2e26 Pull Request resolved: #69368
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jamesr66a
approved these changes
Dec 6, 2021
desertfire
pushed a commit
that referenced
this pull request
Dec 13, 2021
Summary: Pull Request resolved: #69368 Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Imported from OSS Reviewed By: jamesr66a Differential Revision: D32835248 fbshipit-source-id: 91610fd8d05f5683cfa5e11fb6f9f3feacb8e241
desertfire
pushed a commit
that referenced
this pull request
Dec 14, 2021
Summary: Pull Request resolved: #69368 Before this PR, copying a node would lose the stack trace. This PR ensures that the stack trace is preserved across copies. This is useful because quantization passes would like to start allowing the user to preserve stack traces, and we use the copy behavior. Test Plan: ``` python test/test_fx.py TestFX.test_stack_traces ``` Imported from OSS Reviewed By: jamesr66a Differential Revision: D32835248 fbshipit-source-id: 91610fd8d05f5683cfa5e11fb6f9f3feacb8e241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Before this PR, copying a node would lose the stack trace. This PR
ensures that the stack trace is preserved across copies.
This is useful because quantization passes would like to start
allowing the user to preserve stack traces, and we use the copy
behavior.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D32835248