add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse #69416

dev-jwel · 2021-12-04T08:40:05Z

Ref #3158
Note: don't worry about autograd.

pytorch-probot · 2021-12-04T08:40:07Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/dev-jwel/pytorch/blob/39502b11e27045abf1462922f6d6d71efcf5a2ce/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-cuda11.5-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/xla`	✅ triggered
linux-vulkan-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`	✅ triggered
linux-xenial-py3.6-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`	✅ triggered
linux-xenial-py3.6-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`	✅ triggered
linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
docker-builds	`ciflow/all`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`	🚫 skipped
libtorch-linux-bionic-cuda11.5-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`	🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2021-12-04T08:40:09Z

Hi @dev-jwel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2021-12-04T08:40:10Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/69416
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 39502b1 (more details on the Dr. CI page):

2/2 failures possibly* introduced in this PR
- 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_build (1/1)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/docker/build.sh
Auto-merging .circleci/docker/build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/nightly_ios.py
Auto-merging .circleci/cimodel/data/simple/nightly_ios.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm4.3.1-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2021-12-04T09:09:19Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

…ng))

pearu

Thanks, @dev-jwel , for this PR!
I have a number of nits, a request to add a hybrid tensor test case, and a suggestion to merge mul_out_sparse_dense_cpu and mul_out_sparse_dense_cuda into one function mul_out_sparse_dense.

aten/src/ATen/native/sparse/SparseTensorMath.cpp

aten/src/ATen/native/sparse/cuda/SparseCUDATensorMath.cu

test/test_sparse.py

dev-jwel · 2021-12-16T07:37:38Z

Thank you for your review, @pearu!
Your review seems reasonable.
I pushed new commit to address your suggestion.
Please review again.
Thank you!

IvanYashchuk · 2022-03-11T08:52:39Z

Note: there is another attempt of adding mul(sparse, dense): #9481.

github-actions · 2022-05-21T23:36:14Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse

303910f

pytorch-probot bot added the ciflow/default label Dec 4, 2021

pytorchbot added the open source label Dec 4, 2021

dev-jwel added 2 commits December 4, 2021 17:48

fix for Lint/flake8-py3

4861fbe

fix Lint/flake8-py3 again

e538681

facebook-github-bot added the cla signed label Dec 4, 2021

dev-jwel added 2 commits December 4, 2021 18:46

fix test error for sparse mul (sparse mul supports mul(sparse, dense))

7edfe96

remove support for mul(dense, sparse), (mul(sparse, dense) is remaini…

2079092

…ng))

zou3519 requested a review from cpuhrsch December 7, 2021 19:16

zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 7, 2021

cpuhrsch requested review from IvanYashchuk and pearu December 7, 2021 20:11

pearu requested changes Dec 13, 2021

View reviewed changes

pearu added this to In progress in Sparse tensors via automation Dec 14, 2021

dev-jwel added 3 commits December 16, 2021 16:00

address change request

3cbbeeb

fix stuff

75c955b

address change request

39502b1

IvanYashchuk mentioned this pull request Mar 11, 2022

Feature request: mul(Sparse, Dense) -> Sparse #2909

Closed

IvanYashchuk added the module: sparse Related to torch.sparse label Mar 11, 2022

suo removed the ciflow/default label Mar 22, 2022

github-actions bot added the Stale label May 21, 2022

github-actions bot closed this Jun 21, 2022

Sparse tensors automation moved this from In progress to Done Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse #69416

add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse #69416

dev-jwel commented Dec 4, 2021 •

edited by IvanYashchuk

pytorch-probot bot commented Dec 4, 2021 •

edited

⚛️ CI Flow

facebook-github-bot commented Dec 4, 2021

facebook-github-bot commented Dec 4, 2021 •

edited

facebook-github-bot commented Dec 4, 2021

pearu left a comment

dev-jwel commented Dec 16, 2021

IvanYashchuk commented Mar 11, 2022

github-actions bot commented May 21, 2022

add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse #69416

add mul_ function for sparse Tensor, mul_(dense, sparse) -> sparse #69416

Conversation

dev-jwel commented Dec 4, 2021 • edited by IvanYashchuk

pytorch-probot bot commented Dec 4, 2021 • edited

⚛️ CI Flow

facebook-github-bot commented Dec 4, 2021

Action Required

Process

facebook-github-bot commented Dec 4, 2021 • edited

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_build (1/1)

ci.pytorch.org: 1 failed

facebook-github-bot commented Dec 4, 2021

pearu left a comment

Choose a reason for hiding this comment

dev-jwel commented Dec 16, 2021

IvanYashchuk commented Mar 11, 2022

github-actions bot commented May 21, 2022

dev-jwel commented Dec 4, 2021 •

edited by IvanYashchuk

pytorch-probot bot commented Dec 4, 2021 •

edited

facebook-github-bot commented Dec 4, 2021 •

edited