Add hascuSOLVER flag to Context #69825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per title. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Dec 13, 2021
lezcano
added
module: linear algebra
|
Maybe we should also expose |
|
I'll wait for the CI to pass. If it does, I'll add those things to this PR. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4046a86 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mruberry
reviewed
Dec 18, 2021
aten/src/ATen/Context.h
Outdated
| @@ -74,6 +74,9 @@ class TORCH_API Context { | |||
| static long versionCuDNN() { | |||
| return detail::getCUDAHooks().versionCuDNN(); | |||
| } | |||
| static bool hascuSOLVER() { | |||
There was a problem hiding this comment.
I get this should be hasCuSOLVER to be consistent with versionCuDNN above and hasCuSOLVER() from CUDAHooks?
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
approved these changes
Dec 18, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Differential Revision: [D33202687](https://our.internmc.facebook.com/intern/diff/D33202687) [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
Summary: Pull Request resolved: #69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 25, 2022
Summary: Pull Request resolved: #69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69 (cherry picked from commit 7ca16be)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69 (cherry picked from commit 7ca16be)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69 (cherry picked from commit 7ca16be)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69 (cherry picked from commit 7ca16be)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69825 As per title. cc ngimel jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Test Plan: Imported from OSS Reviewed By: mikaylagawarecki, ngimel Differential Revision: D33751986 Pulled By: mruberry fbshipit-source-id: 8625c7246d627b5c3680d92d4e8afdd7efc7dd69 (cherry picked from commit 7ca16be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As per title.
cc @ngimel @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano
Differential Revision: D33751986