Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jit] Polymorphic IValue::type() for DynamicType. #70120

Closed
wants to merge 17 commits into from

Commits on Dec 17, 2021

  1. [jit] Polymorphic IValue::type() for DynamicType.

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    ee09a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    45e0d0c View commit details
    Browse the repository at this point in the history
  2. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    ae138ab View commit details
    Browse the repository at this point in the history
  3. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    dcbf069 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e8b5fe4 View commit details
    Browse the repository at this point in the history
  2. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    07783fc View commit details
    Browse the repository at this point in the history
  3. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    883ea7a View commit details
    Browse the repository at this point in the history
  4. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e7a8f03 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    9987809 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    6b32746 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    09e1f54 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    81ad873 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    2c16266 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1d2b253 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    6df124a View commit details
    Browse the repository at this point in the history
  2. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    00f1ad8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Update on "[jit] Polymorphic IValue::type() for DynamicType."

    Before the change:
    ```
    c10::Type t = ivalue.type();
    ```
    After the change:
    ```
    c10::Type t = ivalue.type();
    c10::DynamicType d = ivalue.type<c10::DynamicType>(); // new path
    ```
    The new path will be adopted in PyTorch Lite Interpreter to support lightweight type reflection. Note that type getters are selected at compile time so no performance overhead. The benefits of having a DynamicType will be elaborated in a separate document, but in short, DynamicType provides an isolated type system for controlling binary size bloat, and shrink down ~20 supported Type symbols into one so that the size taken by specializations and function name symbols are greatly reduced.
    
    Lite Interpreter should only use the `<DynamicType>` variant of the interfaces from aten, to reduce binary size.
    
    Differential Revision: [D33102276](https://our.internmc.facebook.com/intern/diff/D33102276/)
    
    [ghstack-poisoned]
    zhxchen17 committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    9553998 View commit details
    Browse the repository at this point in the history