Set correct device id on efficientzerotensors #71611

anjali411 · 2022-01-21T00:31:50Z

Stack from ghstack:

-> Set correct device id on efficientzerotensors #71611

Fixes #71160 #69925 #69913

Differential Revision: D33897543

[ghstack-poisoned]

pytorch-probot · 2022-01-21T00:31:53Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/2be98f4b0fb1dff3f6d1600f68003366ef2a6a75/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-21T00:31:56Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/71611
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit cf911cf (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[ghstack-poisoned]

ghstack-source-id: deea6fae93c83f981592420ed5dfd3c37d20a885 Pull Request resolved: #71611

[ghstack-poisoned]

ghstack-source-id: aada6c4b91d7dd2f8067fb6b3479dd9dadf7bb87 Pull Request resolved: #71611

[ghstack-poisoned]

ghstack-source-id: 2c91104b26afb55e74fdba56ff9a206247ae4bce Pull Request resolved: #71611

[ghstack-poisoned]

ghstack-source-id: 62ffb9eebaa74af4c1162aea28aafeefc91f8312 Pull Request resolved: #71611

c10/core/TensorImpl.h

test/test_torch.py

Fixes #71160 [ghstack-poisoned]

ghstack-source-id: 6558bc7b7ffbbbacc8edcf4655e27230c3b5a526 Pull Request resolved: #71611

albanD

Thanks!

anjali411 · 2022-01-25T16:57:58Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Fixes #71160 #69925 Differential Revision: [D33768645](https://our.internmc.facebook.com/intern/diff/D33768645) [ghstack-poisoned]

ghstack-source-id: 72e983631f88a631bd033b634df9bc4d9f42e99f Pull Request resolved: #71611

anjali411 · 2022-01-25T21:35:15Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Fixes #71160 #69925 #69913 Differential Revision: [D33897543](https://our.internmc.facebook.com/intern/diff/D33897543) [ghstack-poisoned]

ghstack-source-id: e966030d000b16094aec6f3a0c24abf1a1079309 Pull Request resolved: #71611

anjali411 · 2022-02-02T21:37:55Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #71611 Fixes #71160 #69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5

Summary: Pull Request resolved: #71611 Fixes #71160 #69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5 (cherry picked from commit 643e666)

github-actions · 2022-02-02T21:52:07Z

Hey anjali411.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 Test Plan: Imported from OSS Reviewed By: pbelevich, ngimel Differential Revision: D33768645 Pulled By: anjali411 fbshipit-source-id: 66ce9907630b65a12c0775077147a7e72ff4cee4 (cherry picked from commit 3af98a4)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 Test Plan: Imported from OSS Reviewed By: george-qi Differential Revision: D33834916 Pulled By: anjali411 fbshipit-source-id: 11cec343e95e2ee188ab7576f26f64aa19317891 (cherry picked from commit f6e86f8)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5 (cherry picked from commit 643e666)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 Test Plan: Imported from OSS Reviewed By: pbelevich, ngimel Differential Revision: D33768645 Pulled By: anjali411 fbshipit-source-id: 66ce9907630b65a12c0775077147a7e72ff4cee4 (cherry picked from commit 3af98a4)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 Test Plan: Imported from OSS Reviewed By: george-qi Differential Revision: D33834916 Pulled By: anjali411 fbshipit-source-id: 11cec343e95e2ee188ab7576f26f64aa19317891 (cherry picked from commit f6e86f8)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5 (cherry picked from commit 643e666)

anjali411 · 2022-02-07T17:03:50Z

was merged before the 1.11 branch cut

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 Test Plan: Imported from OSS Reviewed By: pbelevich, ngimel Differential Revision: D33768645 Pulled By: anjali411 fbshipit-source-id: 66ce9907630b65a12c0775077147a7e72ff4cee4 (cherry picked from commit 3af98a4)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 Test Plan: Imported from OSS Reviewed By: george-qi Differential Revision: D33834916 Pulled By: anjali411 fbshipit-source-id: 11cec343e95e2ee188ab7576f26f64aa19317891 (cherry picked from commit f6e86f8)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5 (cherry picked from commit 643e666)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 Test Plan: Imported from OSS Reviewed By: pbelevich, ngimel Differential Revision: D33768645 Pulled By: anjali411 fbshipit-source-id: 66ce9907630b65a12c0775077147a7e72ff4cee4 (cherry picked from commit 3af98a4)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 Test Plan: Imported from OSS Reviewed By: george-qi Differential Revision: D33834916 Pulled By: anjali411 fbshipit-source-id: 11cec343e95e2ee188ab7576f26f64aa19317891 (cherry picked from commit f6e86f8)

Summary: Pull Request resolved: pytorch/pytorch#71611 Fixes pytorch/pytorch#71160 pytorch/pytorch#69925 #69913 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D33897543 Pulled By: anjali411 fbshipit-source-id: f1d8608c351876b8c2619da5ef891f74bad30ab5 (cherry picked from commit 643e666)

Set correct device id on efficientzerotensors

9acca36

[ghstack-poisoned]

anjali411 requested a review from ezyang as a code owner January 21, 2022 00:31

pytorch-probot bot added the ciflow/default label Jan 21, 2022

facebook-github-bot added the cla signed label Jan 21, 2022

Update on "Set correct device id on efficientzerotensors"

87d28e9

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 21, 2022

Set correct device id on efficientzerotensors

326d47d

ghstack-source-id: deea6fae93c83f981592420ed5dfd3c37d20a885 Pull Request resolved: #71611

anjali411 removed the request for review from ezyang January 21, 2022 16:17

Update on "Set correct device id on efficientzerotensors"

2be98f4

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 21, 2022

Set correct device id on efficientzerotensors

b7b0eee

ghstack-source-id: aada6c4b91d7dd2f8067fb6b3479dd9dadf7bb87 Pull Request resolved: #71611

Update on "Set correct device id on efficientzerotensors"

f580a2d

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 24, 2022

Set correct device id on efficientzerotensors

46c4f55

ghstack-source-id: 2c91104b26afb55e74fdba56ff9a206247ae4bce Pull Request resolved: #71611

Update on "Set correct device id on efficientzerotensors"

eff0fa7

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 24, 2022

Set correct device id on efficientzerotensors

71771b1

ghstack-source-id: 62ffb9eebaa74af4c1162aea28aafeefc91f8312 Pull Request resolved: #71611

anjali411 requested review from albanD and ngimel January 24, 2022 17:51

anjali411 added ZeroTensor triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 24, 2022

albanD reviewed Jan 24, 2022

View reviewed changes

c10/core/TensorImpl.h Outdated Show resolved Hide resolved

test/test_torch.py Outdated Show resolved Hide resolved

Update on "Set correct device id on efficientzerotensors"

0c745c3

Fixes #71160 [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 24, 2022

Set correct device id on efficientzerotensors

a20738f

ghstack-source-id: 6558bc7b7ffbbbacc8edcf4655e27230c3b5a526 Pull Request resolved: #71611

anjali411 requested a review from albanD January 24, 2022 20:55

albanD approved these changes Jan 24, 2022

View reviewed changes

Update on "Set correct device id on efficientzerotensors"

baeaa43

Fixes #71160 #69925 Differential Revision: [D33768645](https://our.internmc.facebook.com/intern/diff/D33768645) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 25, 2022

Set correct device id on efficientzerotensors

c04ad89

ghstack-source-id: 72e983631f88a631bd033b634df9bc4d9f42e99f Pull Request resolved: #71611

ngimel approved these changes Jan 25, 2022

View reviewed changes

anjali411 added this to the 1.11.0 milestone Feb 2, 2022

Update on "Set correct device id on efficientzerotensors"

cf911cf

Fixes #71160 #69925 #69913 Differential Revision: [D33897543](https://our.internmc.facebook.com/intern/diff/D33897543) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 2, 2022

Set correct device id on efficientzerotensors

dd96b39

ghstack-source-id: e966030d000b16094aec6f3a0c24abf1a1079309 Pull Request resolved: #71611

pytorchmergebot closed this Feb 2, 2022

anjali411 added release notes: autograd release notes category topic: bug fixes topic category labels Feb 2, 2022

This was referenced Feb 3, 2022

[rocm] Memory Exception on virtual address #70027

Closed

Forward-over-reverse gradgradcheck fails for torch.gradient on CUDA #69925

Closed

anjali411 removed this from the 1.11.0 milestone Feb 7, 2022

davidberard98 mentioned this pull request Feb 8, 2022

[JIT] Opinfo tests for nnc fusion - retry #72486

Closed

soulitzer mentioned this pull request Feb 8, 2022

Forward-over-reverse gradgradcheck fails on CUDA for div.floor_rounding #69913

Closed

facebook-github-bot deleted the gh/anjali411/146/head branch March 5, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set correct device id on efficientzerotensors #71611

Set correct device id on efficientzerotensors #71611

anjali411 commented Jan 21, 2022 •

edited

pytorch-probot bot commented Jan 21, 2022 •

edited by pytorch-bot bot

⚛️ CI Flow

facebook-github-bot commented Jan 21, 2022 •

edited

albanD left a comment

anjali411 commented Jan 25, 2022

anjali411 commented Jan 25, 2022

anjali411 commented Feb 2, 2022

github-actions bot commented Feb 2, 2022

anjali411 commented Feb 7, 2022

Set correct device id on efficientzerotensors #71611

Set correct device id on efficientzerotensors #71611

Conversation

anjali411 commented Jan 21, 2022 • edited

pytorch-probot bot commented Jan 21, 2022 • edited by pytorch-bot bot

⚛️ CI Flow

facebook-github-bot commented Jan 21, 2022 • edited

🔗 Helpful links

💊 CI failures summary and remediations

albanD left a comment

Choose a reason for hiding this comment

anjali411 commented Jan 25, 2022

anjali411 commented Jan 25, 2022

anjali411 commented Feb 2, 2022

github-actions bot commented Feb 2, 2022

anjali411 commented Feb 7, 2022

anjali411 commented Jan 21, 2022 •

edited

pytorch-probot bot commented Jan 21, 2022 •

edited by pytorch-bot bot

facebook-github-bot commented Jan 21, 2022 •

edited