[PyTorchEdge] backport v8 to v7 to support promoted ops as instruction #71662

pavithranrao · 2022-01-21T23:22:51Z

Backport v8 to v7 to support promoted ops as instruction

Summary:
Version bump to V8.

Changes introduced:

Promoted ops (ops from lookup table) are made as instructions
RaiseException now supports an additional optional argument that provides the exception message to debug
V7 and below will continue to use operators and V8 an above will use instructions.
Backport logic to help with BC

Differential Revision: D33719098

pytorch-bot · 2022-01-21T23:22:56Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pavithranrao/pytorch/blob/3b392dec1a7b63dfdedd3e7215e984abde6a3e0e/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

facebook-github-bot · 2022-01-21T23:22:57Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/71662
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 1e9caa4 (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 broken upstream at merge base 8aa3620 on Feb 14 from 8:02am to 9:18am

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-bionic-py3.7-clang9 / test (xla, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-14T17:02:23.8149923Z /var/lib/jenkins/w... at::Tensor&, const at::Tensor&, c10::string_view)

2022-02-14T17:02:23.8143702Z  at::Tensor XLANativeFunctions::gelu(const at::Tensor& self) {
2022-02-14T17:02:23.8144056Z             ^~~~~~~~~~~~~~~~~~
2022-02-14T17:02:23.8144446Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:13:0:
2022-02-14T17:02:23.8145318Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/XLANativeFunctions.h:182:19: error: candidate is: static at::Tensor torch_xla::XLANativeFunctions::gelu(const at::Tensor&, c10::string_view)
2022-02-14T17:02:23.8146013Z  static at::Tensor gelu(const at::Tensor & self, c10::string_view approximate);
2022-02-14T17:02:23.8146374Z                    ^~~~
2022-02-14T17:02:23.8147498Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:1514:12: error: prototype for ‘at::Tensor torch_xla::XLANativeFunctions::gelu_backward(const at::Tensor&, const at::Tensor&)’ does not match any in class ‘torch_xla::XLANativeFunctions’
2022-02-14T17:02:23.8148307Z  at::Tensor XLANativeFunctions::gelu_backward(const at::Tensor& grad,
2022-02-14T17:02:23.8148684Z             ^~~~~~~~~~~~~~~~~~
2022-02-14T17:02:23.8149119Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:13:0:
2022-02-14T17:02:23.8149923Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/XLANativeFunctions.h:183:19: error: candidate is: static at::Tensor torch_xla::XLANativeFunctions::gelu_backward(const at::Tensor&, const at::Tensor&, c10::string_view)
2022-02-14T17:02:23.8150848Z  static at::Tensor gelu_backward(const at::Tensor & grad_output, const at::Tensor & self, c10::string_view approximate);
2022-02-14T17:02:23.8151286Z                    ^~~~~~~~~~~~~
2022-02-14T17:02:24.2347270Z [32/179] c++ -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/tensor_impl.o.d -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/tensor_impl.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-02-14T17:02:24.2351842Z cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
2022-02-14T17:02:24.2353036Z In file included from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/core/platform/logging.h:27:0,
2022-02-14T17:02:24.2354192Z                  from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/core/platform/status.h:27,
2022-02-14T17:02:24.2355325Z                  from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/core/lib/core/status.h:19,
2022-02-14T17:02:24.2356387Z                  from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/compiler/xla/status.h:19,
2022-02-14T17:02:24.2357473Z                  from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/compiler/xla/statusor.h:18,
2022-02-14T17:02:24.2358819Z                  from /var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/tensorflow/compiler/xla/client/padding.h:23,

periodic-win-vs2019-cuda11.1-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-14T20:43:43.7503488Z RuntimeError: test_ops failed!

2022-02-14T20:43:30.6693792Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestGradientsCUDA-20220214191128.xml
2022-02-14T20:43:30.6695294Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestJitCPU-20220214191128.xml
2022-02-14T20:43:30.6696682Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestJitCUDA-20220214191128.xml
2022-02-14T20:43:30.6698172Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestMathBitsCPU-20220214191128.xml
2022-02-14T20:43:30.6699748Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestMathBitsCUDA-20220214191128.xml
2022-02-14T20:43:43.7499703Z Traceback (most recent call last):
2022-02-14T20:43:43.7500733Z   File "run_test.py", line 1088, in <module>
2022-02-14T20:43:43.7501213Z     main()
2022-02-14T20:43:43.7502254Z   File "run_test.py", line 1066, in main
2022-02-14T20:43:43.7502917Z     raise RuntimeError(err_message)
2022-02-14T20:43:43.7503488Z RuntimeError: test_ops failed!
2022-02-14T20:43:44.1222278Z 
2022-02-14T20:43:44.1223591Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-02-14T20:43:44.1229604Z 
2022-02-14T20:43:44.1230287Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-02-14T20:43:44.1264687Z + cleanup
2022-02-14T20:43:44.1265396Z + retcode=1
2022-02-14T20:43:44.1265746Z + set +x
2022-02-14T20:43:44.1303424Z ##[error]Process completed with exit code 1.
2022-02-14T20:43:44.2107009Z ##[group]Run # -ir => recursive include all files in pattern
2022-02-14T20:43:44.2107906Z �[36;1m# -ir => recursive include all files in pattern�[0m

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

linux-xenial-py3.7-clang7-onnx / test (default, 1, 2, linux.2xlarge) on Feb 14 from 8:02am to 9:18am (8aa3620 - 8aa3620)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2022-01-21T23:23:21Z

This pull request was exported from Phabricator. Differential Revision: D33719098

iseeyuan · 2022-01-22T02:28:50Z

torch/csrc/jit/runtime/interpreter/code_impl.h

@@ -890,10 +904,25 @@ struct MobileCodeImpl : CodeImpl {
    }
  }

+  void emitOperatorOrInstruction(


@zhxchen17 , could help review the emitting part?

cccclai · 2022-01-25T06:47:55Z

LGTM. Thanks! Could you also update the module

pytorch/test/cpp/jit/test_lite_interpreter.cpp

Lines 629 to 645 in deb1c2f

    
             torch::jit::Module module("m"); 
        
             // NOLINTNEXTLINE(cppcoreguidelines-avoid-magic-numbers) 
        
             module.register_parameter("weight", torch::ones({20, 1, 5, 5}), false); 
        
             // NOLINTNEXTLINE(cppcoreguidelines-avoid-magic-numbers) 
        
             module.register_parameter("bias", torch::ones({20}), false); 
        
             module.define(R"( 
        
               def forward(self, input): 
        
                 x1 = torch.zeros(2, 2) 
        
                 x2 = torch.empty_like(torch.empty(2, 2)) 
        
                 x3 = torch._convolution(input, self.weight, self.bias, [1, 1], [0, 0], [1, 1], False, [0, 0], 1, False, False, True, True) 
        
                 # Add torch.add operator to cover bytecode version bump from 6 to 7 
        
                 # for bytecode version 7, the main change is to support defaults arguments with out arguments 
        
                 x = 2 * torch.ones(1) 
        
                 h = torch.ones(1) 
        
                 torch.add(x, h, out=x) 
        
                 return (x1, x2, x3, x) 
        
             )");

and make it also covers on of the promoted ops?

facebook-github-bot · 2022-01-25T16:59:18Z

This pull request was exported from Phabricator. Differential Revision: D33719098

facebook-github-bot · 2022-01-25T23:08:03Z

This pull request was exported from Phabricator. Differential Revision: D33719098

facebook-github-bot · 2022-01-27T17:14:21Z

This pull request was exported from Phabricator. Differential Revision: D33719098

pytorch#71662) Summary: Pull Request resolved: pytorch#71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` Differential Revision: D33719098 fbshipit-source-id: 4f994c7e196a5838ea9376067a0233c0bf52de9c

facebook-github-bot · 2022-02-02T17:11:17Z

This pull request was exported from Phabricator. Differential Revision: D33719098

facebook-github-bot · 2022-02-02T17:25:17Z

This pull request was exported from Phabricator. Differential Revision: D33719098

pytorch#71662) Summary: Pull Request resolved: pytorch#71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` Differential Revision: D33719098 fbshipit-source-id: 967e6384271d012a10c3ef619122a38a1f43330c

facebook-github-bot · 2022-02-03T00:14:59Z

This pull request was exported from Phabricator. Differential Revision: D33719098

pytorch#71662) Summary: Pull Request resolved: pytorch#71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` ``` buck run mode/opt //caffe2/torch/fb/mobile/upgrader_codegen:upgrader_codegen buck test mode/opt //caffe2/test:upgrader_codegen -- mobile.test_upgrader_codegen.TestLiteScriptModule Parsing buck files: finished in 0.8 sec Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 01:39.4 min (100%) 11031/11031 jobs, 2/11031 updated Total time: 01:40.2 min More details at https://www.internalfb.com/intern/buck/build/a8b0e417-019c-44ba-be6b-23379411a965 BUILD SUCCEEDED Tpx test run coordinator for Facebook. See https://fburl.com/tpx for details. Running with tpx session id: 44fbfa66-cce8-4277-82ac-f89d79558581 Trace available for this run at /tmp/tpx-20220202-160956.915412/trace.log RemoteExecution session id: reSessionID-44fbfa66-cce8-4277-82ac-f89d79558581-tpx Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ✓ ListingSuccess: caffe2/test:upgrader_codegen : 1 tests discovered (1.249) ✓ Pass: caffe2/test:upgrader_codegen - test_generate_bytecode (mobile.test_upgrader_codegen.TestLiteScriptModule) (1.365) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ``` Differential Revision: D33719098 fbshipit-source-id: f927e324a2043c30139c59d56110ac001e4e7df8

iseeyuan

LGTM. Please make sure test all production models

In v8
backport to v7

pytorch#71662) Summary: Pull Request resolved: pytorch#71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` ``` buck run mode/opt //caffe2/torch/fb/mobile/upgrader_codegen:upgrader_codegen buck test mode/opt //caffe2/test:upgrader_codegen -- mobile.test_upgrader_codegen.TestLiteScriptModule Parsing buck files: finished in 0.8 sec Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 01:39.4 min (100%) 11031/11031 jobs, 2/11031 updated Total time: 01:40.2 min More details at https://www.internalfb.com/intern/buck/build/a8b0e417-019c-44ba-be6b-23379411a965 BUILD SUCCEEDED Tpx test run coordinator for Facebook. See https://fburl.com/tpx for details. Running with tpx session id: 44fbfa66-cce8-4277-82ac-f89d79558581 Trace available for this run at /tmp/tpx-20220202-160956.915412/trace.log RemoteExecution session id: reSessionID-44fbfa66-cce8-4277-82ac-f89d79558581-tpx Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ✓ ListingSuccess: caffe2/test:upgrader_codegen : 1 tests discovered (1.249) ✓ Pass: caffe2/test:upgrader_codegen - test_generate_bytecode (mobile.test_upgrader_codegen.TestLiteScriptModule) (1.365) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ``` Reviewed By: iseeyuan Differential Revision: D33719098 fbshipit-source-id: 93a25e69e7d3c29f027e4f9d04fdb1c27cbe2400

facebook-github-bot · 2022-02-14T16:27:51Z

This pull request was exported from Phabricator. Differential Revision: D33719098

#71662) Summary: Pull Request resolved: #71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` ``` buck run mode/opt //caffe2/torch/fb/mobile/upgrader_codegen:upgrader_codegen buck test mode/opt //caffe2/test:upgrader_codegen -- mobile.test_upgrader_codegen.TestLiteScriptModule Parsing buck files: finished in 0.8 sec Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 01:39.4 min (100%) 11031/11031 jobs, 2/11031 updated Total time: 01:40.2 min More details at https://www.internalfb.com/intern/buck/build/a8b0e417-019c-44ba-be6b-23379411a965 BUILD SUCCEEDED Tpx test run coordinator for Facebook. See https://fburl.com/tpx for details. Running with tpx session id: 44fbfa66-cce8-4277-82ac-f89d79558581 Trace available for this run at /tmp/tpx-20220202-160956.915412/trace.log RemoteExecution session id: reSessionID-44fbfa66-cce8-4277-82ac-f89d79558581-tpx Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ✓ ListingSuccess: caffe2/test:upgrader_codegen : 1 tests discovered (1.249) ✓ Pass: caffe2/test:upgrader_codegen - test_generate_bytecode (mobile.test_upgrader_codegen.TestLiteScriptModule) (1.365) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ``` Reviewed By: iseeyuan Differential Revision: D33719098 fbshipit-source-id: e2d2b23d298f98e4d4fcdfc344f7b8c6f92cff26

github-actions · 2022-02-15T03:48:12Z

Hey @pavithranrao.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…n (#71662) Summary: Pull Request resolved: pytorch/pytorch#71662 backport v8 to v7 to support promoted ops as instruction a flag to help export as instruction from v8 and export as operators for v7 and below Test Plan: ``` buck test caffe2/test/cpp/jit:jit -- LiteInterpreterTest.BackPortByteCodeModelAllVersions Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ✓ ListingSuccess: caffe2/test/cpp/jit:jit : 461 tests discovered (15.693) ✓ Pass: caffe2/test/cpp/jit:jit - LiteInterpreterTest.BackPortByteCodeModelAllVersions (2.712) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/5629499620570927 ``` ``` buck run mode/opt //caffe2/torch/fb/mobile/upgrader_codegen:upgrader_codegen buck test mode/opt //caffe2/test:upgrader_codegen -- mobile.test_upgrader_codegen.TestLiteScriptModule Parsing buck files: finished in 0.8 sec Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 01:39.4 min (100%) 11031/11031 jobs, 2/11031 updated Total time: 01:40.2 min More details at https://www.internalfb.com/intern/buck/build/a8b0e417-019c-44ba-be6b-23379411a965 BUILD SUCCEEDED Tpx test run coordinator for Facebook. See https://fburl.com/tpx for details. Running with tpx session id: 44fbfa66-cce8-4277-82ac-f89d79558581 Trace available for this run at /tmp/tpx-20220202-160956.915412/trace.log RemoteExecution session id: reSessionID-44fbfa66-cce8-4277-82ac-f89d79558581-tpx Started reporting to test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ✓ ListingSuccess: caffe2/test:upgrader_codegen : 1 tests discovered (1.249) ✓ Pass: caffe2/test:upgrader_codegen - test_generate_bytecode (mobile.test_upgrader_codegen.TestLiteScriptModule) (1.365) Summary Pass: 1 ListingSuccess: 1 If you need help understanding your runs, please follow the wiki: https://fburl.com/posting_in_tpx_users Finished test run: https://www.internalfb.com/intern/testinfra/testrun/281475200877601 ``` Reviewed By: iseeyuan Differential Revision: D33719098 fbshipit-source-id: e2d2b23d298f98e4d4fcdfc344f7b8c6f92cff26 (cherry picked from commit 81b956c23abc19489b69eee986721252474d00dc)

pytorch-bot bot added the ciflow/default label Jan 21, 2022

facebook-github-bot added the cla signed label Jan 21, 2022

facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Jan 21, 2022

iseeyuan reviewed Jan 22, 2022

View reviewed changes

iseeyuan requested a review from cccclai January 25, 2022 15:36

pavithranrao force-pushed the export-D33719098 branch from 3b392de to 8c2ae04 Compare January 25, 2022 16:59

pavithranrao force-pushed the export-D33719098 branch from 8c2ae04 to 34f4bd2 Compare January 25, 2022 23:08

pavithranrao force-pushed the export-D33719098 branch from 34f4bd2 to f8ff95f Compare January 27, 2022 17:14

pavithranrao added the ciflow/all label Feb 1, 2022

pavithranrao force-pushed the export-D33719098 branch from f8ff95f to 346d61b Compare February 2, 2022 17:11

pavithranrao force-pushed the export-D33719098 branch from 346d61b to f68e60a Compare February 2, 2022 17:25

pavithranrao force-pushed the export-D33719098 branch from f68e60a to f5e8056 Compare February 3, 2022 00:14

iseeyuan approved these changes Feb 3, 2022

View reviewed changes

pavithranrao force-pushed the export-D33719098 branch from f5e8056 to 1e9caa4 Compare February 14, 2022 16:27

pytorchmergebot closed this in a482aeb Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PyTorchEdge] backport v8 to v7 to support promoted ops as instruction #71662

[PyTorchEdge] backport v8 to v7 to support promoted ops as instruction #71662

pavithranrao commented Jan 21, 2022 •

edited

pytorch-bot bot commented Jan 21, 2022

⚛️ CI Flow

facebook-github-bot commented Jan 21, 2022 •

edited

facebook-github-bot commented Jan 21, 2022

iseeyuan Jan 22, 2022

cccclai commented Jan 25, 2022

facebook-github-bot commented Jan 25, 2022

facebook-github-bot commented Jan 25, 2022

facebook-github-bot commented Jan 27, 2022

facebook-github-bot commented Feb 2, 2022

facebook-github-bot commented Feb 2, 2022

facebook-github-bot commented Feb 3, 2022

iseeyuan left a comment

facebook-github-bot commented Feb 14, 2022

github-actions bot commented Feb 15, 2022

[PyTorchEdge] backport v8 to v7 to support promoted ops as instruction #71662

[PyTorchEdge] backport v8 to v7 to support promoted ops as instruction #71662

Conversation

pavithranrao commented Jan 21, 2022 • edited

pytorch-bot bot commented Jan 21, 2022

⚛️ CI Flow

facebook-github-bot commented Jan 21, 2022 • edited

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

linux-bionic-py3.7-clang9 / test (xla, 1, 1, linux.2xlarge) (1/2)

periodic-win-vs2019-cuda11.1-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) (2/2)

🚧 1 fixed upstream failure:

facebook-github-bot commented Jan 21, 2022

iseeyuan Jan 22, 2022

Choose a reason for hiding this comment

cccclai commented Jan 25, 2022

facebook-github-bot commented Jan 25, 2022

facebook-github-bot commented Jan 25, 2022

facebook-github-bot commented Jan 27, 2022

facebook-github-bot commented Feb 2, 2022

facebook-github-bot commented Feb 2, 2022

facebook-github-bot commented Feb 3, 2022

iseeyuan left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 14, 2022

github-actions bot commented Feb 15, 2022

pavithranrao commented Jan 21, 2022 •

edited

facebook-github-bot commented Jan 21, 2022 •

edited