Add support for legacy tensor constructors in JIT #74785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7569cc3 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
| Job | Step | Action |
|---|---|---|
 pull / linux-bionic-rocm5.0-py3.7 / test (default, 2, 2, linux.rocm.gpu) |
Set up job | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
the
oncall: jit
eellison
pushed a commit
that referenced
this pull request
Mar 25, 2022
ghstack-source-id: f60220bb5e31e49b89da74ded055c302b02e79c6 Pull Request resolved: #74785
eellison
changed the title
Fix for https://github.com/facebookresearch/torchdynamo/issues/93 Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter. [ghstack-poisoned]
Fix for https://github.com/facebookresearch/torchdynamo/issues/93 Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter. [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Mar 28, 2022
ghstack-source-id: 853fde07fd30e0aaa9eb723f5418df171c2fc0e5 Pull Request resolved: #74785
ansley
approved these changes
Mar 30, 2022
| for (const auto& name : tensor_names) { | ||
| if (obj.ptr() == py::module::import("torch").attr(name.first).ptr()) { | ||
| return LegacyTensorConstructor::create( | ||
| prim::LegacyTypedConstructor, name.second, at::kCPU); |
There was a problem hiding this comment.
This is my own lack of knowledge showing, but why do we assume that the Tensor will be on the CPU?
There was a problem hiding this comment.
I should add a comment or just remove the argument. The legacy constructors always are instigated on CPU. There is separately from torch.LongTensor (cpu) torch.cuda.LongTensor (cuda). I added the device argument without actually adding support for torch.cuda.LongTensor so I can just remove it for now
Fix for https://github.com/facebookresearch/torchdynamo/issues/93 Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter. [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Mar 31, 2022
ghstack-source-id: 7cb4972b803dd7cdb87589490b18bfc68e4d6a71 Pull Request resolved: #74785
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Fix for https://github.com/facebookresearch/torchdynamo/issues/93 Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter. Differential Revision: [D35362762](https://our.internmc.facebook.com/intern/diff/D35362762) [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Apr 5, 2022
ghstack-source-id: 769baf5c5208cd8010f4c6b5c5ddba6754823daf Pull Request resolved: #74785
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: Pull Request resolved: #74785 Fix for https://github.com/facebookresearch/torchdynamo/issues/93 Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter. Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D35362762 Pulled By: eellison fbshipit-source-id: 960badf08ba2ab0818af5fd331aff3542051250f
|
Hey @eellison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix for https://github.com/facebookresearch/torchdynamo/issues/93
Because the constructor follow a non-standard input schema (variadic integers), they are handled specially in ir_emitter.
Differential Revision: D35362762