Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fx][ShapeProp] make shapes and args/kwargs concrete for minimizer #75291

Closed
wants to merge 1 commit into from

Conversation

alexbeloi
Copy link
Contributor

Summary: As the title. Also adds debugging messaging to ShapeProp.run_node

Test Plan:
In Amodel

buck run mode/opt //caffe2/torch/fb/acc_runtime/dbg:debug_min_net -- --model 10x_ctr_mbl_feed_tp --model_path /home/$USER/309786571_1.fp32.predictor.tooling.tp

fails later than before

Reviewed By: yuhc

Differential Revision: D34930081

Summary: As the title. Also adds debugging messaging to `ShapeProp.run_node`

Test Plan:
In Amodel
````
buck run mode/opt //caffe2/torch/fb/acc_runtime/dbg:debug_min_net -- --model 10x_ctr_mbl_feed_tp --model_path /home/$USER/309786571_1.fp32.predictor.tooling.tp

````
fails later than before

Reviewed By: yuhc

Differential Revision: D34930081

fbshipit-source-id: a1090109cbd8ca3e060543f0e3bc97cf69011075
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 48e1b0e (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34930081

facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
…75291)

Summary:
Pull Request resolved: #75291

As the title. Also adds debugging messaging to `ShapeProp.run_node`

Reviewed By: yuhc

Differential Revision: D34930081

fbshipit-source-id: ea4341ac2377b7b81404b14afeb5149d5556d92c
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Hey @alexbeloi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants