Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark torch.utils.data.Dataset as iterable #77116

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions torch/utils/data/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
Sequence,
Tuple,
TypeVar,
TYPE_CHECKING,
)

# No 'default_generator' in torch/__init__.pyi
Expand Down Expand Up @@ -53,6 +54,11 @@ def __getitem__(self, index) -> T_co:
def __add__(self, other: 'Dataset[T_co]') -> 'ConcatDataset[T_co]':
return ConcatDataset([self, other])

if TYPE_CHECKING:
# Convince type checkers that Dataset objects are iterable
def __iter__(self) -> Iterator[T_co]:
...

# No `def __len__(self)` default?
# See NOTE [ Lack of Default `__len__` in Python Abstract Base Classes ]
# in pytorch/torch/utils/data/sampler.py
Expand Down