-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full support for serialization of MPS Tensors #79465
Conversation
🔗 Helpful links
❌ 2 New FailuresAs of commit 085e441 (more details on the Dr. CI page): Expand to see more
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakagespull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/2)Step: "Test" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @albanD. |
@pytorchbot revert -m "this broke X linux-xenial-py3.7-clang7-onnx / test (default, 1, 2, linux.2xlarge). Not sure why since it passed on pull." -c landrace |
@pytorchbot successfully started a revert job. Check the current status here |
This reverts commit 64c2a27. Reverted #79465 on behalf of https://github.com/zengk95 due to this broke X linux-xenial-py3.7-clang7-onnx / test (default, 1, 2, linux.2xlarge). Not sure why since it passed on pull.
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here |
thanks so much @albanD; very expedient! |
@pytorchbot merge -f |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @albanD. |
Summary: Fix #79384 Pull Request resolved: #79465 Approved by: https://github.com/kulinseth, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/64c2a275c4d463b936b9469da948a666e016bbb8 Reviewed By: osalpekar Differential Revision: D37156509 Pulled By: malfet fbshipit-source-id: 3c7ece64b0b519662bc7e5f19873bf579c6ffd93
Fix #79384