Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPS: Add multinomial op #80760

Closed
wants to merge 3 commits into from
Closed

Conversation

kulinseth
Copy link
Collaborator

Add multinomial with replacement

@kulinseth kulinseth added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 1, 2022
@kulinseth kulinseth requested a review from razarmehr July 1, 2022 05:58
@kulinseth kulinseth requested a review from bdhirsh as a code owner July 1, 2022 05:58
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 3bb454d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@samdow samdow added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 2, 2022
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kulinseth
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Matched rule superuser, but PR #80760 was not reviewed yet by any of: janeyx99, anirbanr-fb-r2p, MohammadMahdiJavanmard, jeanschmidt, angelayi, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2619468981

@kulinseth kulinseth requested review from malfet and albanD July 6, 2022 15:20
@kulinseth
Copy link
Collaborator Author

kulinseth commented Jul 6, 2022

@malfet, can you please take a look.
Lets hold off on this, we are seeing some Asserts in Debug build with MPS.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/80760

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 2cf8c65:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor

malfet commented Oct 3, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased multinomial_upstream onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout multinomial_upstream && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Oct 3, 2022

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Hey @kulinseth.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022
Add multinomial with replacement

Pull Request resolved: pytorch#80760
Approved by: https://github.com/razarmehr, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants