Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note about katex install for building docs #81550

Closed
wants to merge 1 commit into from
Closed

Added note about katex install for building docs #81550

wants to merge 1 commit into from

Conversation

fdrocha
Copy link
Collaborator

@fdrocha fdrocha commented Jul 15, 2022 •
edited

Stack from ghstack (oldest at bottom):

Currently, the version of katex that npm installs
and the version of nodejs that is installed by conda
from conda-forge are incompatible. This note describes
which version of katex to install to avoid this

@fdrocha
Added note about katex install for building docs
8acf153 
Currently, the version of katex that npm installs
and the version of nodejs that is installed by conda
from conda-forge are incompatible. This note describes
which version of katex to install to avoid this

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 15, 2022 •
edited

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 8acf153 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

fdrocha added a commit that referenced this pull request Jul 15, 2022
@fdrocha
Added note about katex install for building docs
bfda22c 
Currently, the version of katex that npm installs
and the version of nodejs that is installed by conda
from conda-forge are incompatible. This note describes
which version of katex to install to avoid this

ghstack-source-id: 79739293b8c0e086df34162e53b3c7194f1617e6
Pull Request resolved: #81550
@fdrocha fdrocha added the module: docs Related to our documentation, both in docs/ and docblocks label Jul 15, 2022
lezcano
lezcano approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff.

@lezcano lezcano requested a review from ezyang July 15, 2022 10:22
@kit1980
Copy link
Member

kit1980 commented Jul 15, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link

Hey @fdrocha.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 18, 2022
@fdrocha @facebook-github-bot
Added note about katex install for building docs (#81550) (#81550)
9f28f17 
Summary:
Currently, the version of katex that npm installs
and the version of nodejs that is installed by conda
from conda-forge are incompatible. This note describes
which version of katex to install to avoid this

Pull Request resolved: #81550
Approved by: https://github.com/Lezcano, https://github.com/kit1980

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e100e6fd4f92794a88bbcf06da23baad289b10dc

Reviewed By: DanilBaibak

Differential Revision: D37919528

Pulled By: DanilBaibak

fbshipit-source-id: 2a6e2803f2f9f51f89d23725751e83052dcd1937
@facebook-github-bot facebook-github-bot deleted the gh/fdrocha/5/head branch July 19, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@lezcano lezcano lezcano approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
cla signed Merged module: docs Related to our documentation, both in docs/ and docblocks open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fdrocha @facebook-github-bot @kit1980 @pytorchmergebot @lezcano @pytorchbot