Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin windows numpy #82652

Closed
wants to merge 1 commit into from
Closed

Pin windows numpy #82652

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Aug 2, 2022 •
edited

Description

Pinned numpy for windows temporarily. Numpy shouldn't need to be pinned, but its upgrade to 1.23 has wreaked havoc on CI. Never mind about the not pinning!

Issue

Related to #82653

Testing

CI -- win cpu should pass

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 2, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results here

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit d13dccd:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 mentioned this pull request Aug 2, 2022
Closed
@janeyx99
Copy link
Contributor Author

janeyx99 commented Aug 2, 2022

@pytorchbot merge -f "Got past failures, going to merge to unblock trunk asap"

@janeyx99 janeyx99 changed the title Temporarily pin windows numpy Pin windows numpy Aug 2, 2022
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet
Copy link
Contributor

malfet commented Aug 2, 2022

Do you mind submitting a followup PR that somehow re-uses requirements-ci.txt and pins numpy uniformly on both Windows and Linux? (As we want to pin numpy, cause updates to algorithm can cause CI to fail)

atalman pushed a commit to atalman/pytorch that referenced this pull request Aug 2, 2022
@janeyx99 @atalman
Pin windows numpy (pytorch#82652)
1d0ad88 
### Description
Pinned numpy for windows temporarily. Numpy shouldn't need to be pinned, but its upgrade to 1.23 has wreaked havoc on CI. Never mind about the not pinning!

### Issue
Related to pytorch#82653

### Testing
CI -- win cpu should pass
Pull Request resolved: pytorch#82652
Approved by: https://github.com/malfet
@atalman atalman mentioned this pull request Aug 2, 2022
Merged
atalman added a commit that referenced this pull request Aug 2, 2022
@atalman @janeyx99
Pin windows numpy (#82652) (#82686)
664058f 
### Description
Pinned numpy for windows temporarily. Numpy shouldn't need to be pinned, but its upgrade to 1.23 has wreaked havoc on CI. Never mind about the not pinning!

### Issue
Related to #82653

### Testing
CI -- win cpu should pass
Pull Request resolved: #82652
Approved by: https://github.com/malfet

Co-authored-by: Jane Xu <janeyx@fb.com>
facebook-github-bot pushed a commit that referenced this pull request Aug 3, 2022
@janeyx99 @facebook-github-bot
Pin windows numpy (#82652) (#82652)
07e024a 
Summary:
### Description
Pinned numpy for windows temporarily. Numpy shouldn't need to be pinned, but its upgrade to 1.23 has wreaked havoc on CI. Never mind about the not pinning!

### Issue
Related to #82653

### Testing
CI -- win cpu should pass

Pull Request resolved: #82652
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f1f231c4ddbb078ca2e77ea0958df07d8b3b9894

Reviewed By: kit1980

Differential Revision: D38359617

Pulled By: janeyx99

fbshipit-source-id: aa6fe59e7837b360724ceeae2997c39cc60b9fb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janeyx99 @pytorchmergebot @malfet @facebook-github-bot