Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the script doesn't stop eariler on error for MSVC and Ninja #8277

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Fix the script doesn't stop eariler on error for MSVC and Ninja #8277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
611a667
Simplify the solution
peterjc123 Jun 11, 2018
770faad
Remove the usage of set errorlevel
peterjc123 Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .jenkins/pytorch/win-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ mkdir %CD%\\tmp_bin
if "%REBUILD%"=="" (
:check_sccache
%CD%\\tmp_bin\\sccache.exe --show-stats || (
taskkill /im sccache.exe /f /t || set ERRORLEVEL=0
taskkill /im sccache.exe /f /t || ver > nul
del %CD%\\tmp_bin\\sccache.exe
aws s3 cp s3://ossci-windows/sccache.exe %CD%\\tmp_bin\\sccache.exe
goto :check_sccache
Expand Down Expand Up @@ -95,7 +95,8 @@ if "%REBUILD%"=="" (
set NO_CUDA=1
python setup.py install
)
if %errorlevel% neq 0 exit /b %errorlevel%
if errorlevel 1 exit /b 1
if not errorlevel 0 exit /b 1
if "%REBUILD%"=="" (
sccache --show-stats
sccache --zero-stats
Expand Down
6 changes: 4 additions & 2 deletions tools/build_pytorch_libs.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ goto:eof
-DCMAKE_BUILD_TYPE=%BUILD_TYPE%

%MAKE_COMMAND%
IF NOT %ERRORLEVEL%==0 exit 1
IF ERRORLEVEL 1 exit 1
IF NOT ERRORLEVEL 0 exit 1
cd ../..
@endlocal

Expand Down Expand Up @@ -198,7 +199,8 @@ goto:eof
-DWITH_ROCM=%WITH_ROCM%

%MAKE_COMMAND%
IF NOT %ERRORLEVEL%==0 exit 1
IF ERRORLEVEL 1 exit 1
IF NOT ERRORLEVEL 0 exit 1
cd ..
@endlocal

Expand Down