Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static initialization issue for static build (#83255) #83258

Closed
wants to merge 1 commit into from

Conversation

1enn0
Copy link

@1enn0 1enn0 commented Aug 11, 2022

Fixes #83255

@facebook-github-bot
Copy link
Contributor

Hi @1enn0!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6a01394 (more details on the Dr. CI page):

Expand to see more

Commit 6a01394 was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@soulitzer soulitzer requested a review from malfet August 11, 2022 22:02
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 11, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@1enn0
Copy link
Author

1enn0 commented Sep 12, 2022

Hi @malfet, do you have any comments on this?

@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 1enn0 / name: johnnyflash (6a01394)

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@soumith
Copy link
Member

soumith commented Dec 8, 2022

Hey @1enn0 , sorry for the experience here. Your PR showed up right when we were transitioning a bunch of tooling from Meta-specific infrastructure to Linux Foundation infrastructure, and hence we were stuck in a bit of a mess.

@ppwwyyxx sent the same code as a fresh PR over here, getting over the tooling issues: #90133
Would you have any reservations if we committed that instead?

pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2022
Fixes #83255

Code comes from #83258 after fixing merge conflicts.

Pull Request resolved: #90133
Approved by: https://github.com/soumith, https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@1enn0
Copy link
Author

1enn0 commented Dec 12, 2022

Hi @soumith, no worries! Sure, using @ppwwyyxx's PR is fine with me, and I see it has already happened :)

Sorry for the late reply but I was offline for vacation some time...

@1enn0 1enn0 closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static initialization issue when building LibTorch (CPU) as static lib on Windows
5 participants