-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static initialization issue for static build (#83255) #83258
Conversation
Hi @1enn0! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 6a01394 (more details on the Dr. CI page): Expand to see moreCommit 6a01394 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hi @malfet, do you have any comments on this? |
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Hey @1enn0 , sorry for the experience here. Your PR showed up right when we were transitioning a bunch of tooling from Meta-specific infrastructure to Linux Foundation infrastructure, and hence we were stuck in a bit of a mess. @ppwwyyxx sent the same code as a fresh PR over here, getting over the tooling issues: #90133 |
Fixes #83255 Code comes from #83258 after fixing merge conflicts. Pull Request resolved: #90133 Approved by: https://github.com/soumith, https://github.com/malfet
Fixes pytorch#83255 Code comes from pytorch#83258 after fixing merge conflicts. Pull Request resolved: pytorch#90133 Approved by: https://github.com/soumith, https://github.com/malfet
Fixes #83255