[ONNX] Update the script for version updates #83283

justinchuby · 2022-08-11T18:46:51Z

Stack from ghstack (oldest at bottom):

-> [ONNX] Update the script for version updates #83283

This PR updates the tools/onnx/update_default_opset_version.py script to ensure files are edited correctly to prepare for the opset 17 support in torch.onnx.

(clean up) Move script to main()
Add an --skip_build option to avoid building pytorch if we want to rerun the process due to errors after compilation is done
Update to edit the correct files now that the onnx files were refactored

[ghstack-poisoned]

facebook-github-bot · 2022-08-11T18:46:57Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83283
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 10c0738 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

- Move script to `main()` - Add an `--skip_recompile` option - Remove file edits in `__init__` that do not work anymore [ghstack-poisoned]

thiagocrepaldi

Hi @justinchuby, please provide a clear and concise description of the bug being handled or the feature/refactored being proposed. The PR description gives context for a faster review.

If this is a bug fix, describe the bug, provide a minimal repro, describe the strategy to fix and provide unit tests.
If this is a feature/redesign (seems to be the case), outline the motivation for the proposal. Is your code related to a specific problem? e.g., "I'm working on X and would like Y to be possible". If this is related to another GitHub issue, please link here too.

justinchuby · 2022-08-12T18:45:12Z

Done. PTAL

tools/onnx/update_default_opset_version.py

This PR updates the `tools/onnx/update_default_opset_version.py` script to ensure files are edited correctly to prepare for the opset 17 support in torch.onnx. - (clean up) Move script to `main()` - Add an `--skip_recompile` option to avoid recompiling pytorch if we want to rerun the process due to errors after compilation is done - Remove file edits in `__init__` that do not work anymore [ghstack-poisoned]

titaiwangms · 2022-08-15T17:55:26Z

tools/onnx/update_default_opset_version.py

+if __name__ == "__main__":
+    parser = argparse.ArgumentParser()
+    parser.add_argument(
+        "--skip_build", action="store_true", help="Skip building pytorch"


Please remember to update the change to your description as well.

titaiwangms

🍺

This PR updates the `tools/onnx/update_default_opset_version.py` script to ensure files are edited correctly to prepare for the opset 17 support in torch.onnx. - (clean up) Move script to `main()` - Add an `--skip_build` option to avoid building pytorch if we want to rerun the process due to errors after compilation is done - Update to edit the correct files now that the onnx files were refactored [ghstack-poisoned]

justinchuby · 2022-08-16T17:55:00Z

cc @abock for approval

justinchuby · 2022-08-16T18:59:02Z

@pytorchbot merge

pytorchmergebot · 2022-08-16T19:00:41Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-16T19:00:45Z

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule ONNX exporter
Raised by https://github.com/pytorch/pytorch/actions/runs/2870392115

justinchuby · 2022-08-16T19:01:45Z

@pytorchbot rebase

pytorchmergebot · 2022-08-16T19:58:38Z

@pytorchbot successfully started a rebase job. Check the current status here

This PR updates the `tools/onnx/update_default_opset_version.py` script to ensure files are edited correctly to prepare for the opset 17 support in torch.onnx. - (clean up) Move script to `main()` - Add an `--skip_build` option to avoid building pytorch if we want to rerun the process due to errors after compilation is done - Update to edit the correct files now that the onnx files were refactored [ghstack-poisoned]

pytorchmergebot · 2022-08-16T19:58:57Z

Successfully rebased gh/justinchuby/6/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/83283)

ghstack-source-id: da984a01fae8878e7ee1856c900a2f058a70507a Pull Request resolved: #83283

justinchuby · 2022-08-16T20:32:00Z

@pytorchbot merge -g

pytorchmergebot · 2022-08-16T20:33:21Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Summary: This PR updates the `tools/onnx/update_default_opset_version.py` script to ensure files are edited correctly to prepare for the opset 17 support in torch.onnx. - (clean up) Move script to `main()` - Add an `--skip_build` option to avoid building pytorch if we want to rerun the process due to errors after compilation is done - Update to edit the correct files now that the onnx files were refactored Pull Request resolved: #83283 Approved by: https://github.com/thiagocrepaldi, https://github.com/AllenTiTaiWang, https://github.com/abock Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/cd68f08992e0985f1032726571ebe781aa50f82a Reviewed By: seemethere, atalman Differential Revision: D38770022 fbshipit-source-id: ae372c099b23194328788a0af8cb9f4494d04f18

[ONNX] Update the script for version updates

9ed28a7

[ghstack-poisoned]

facebook-github-bot added the cla signed label Aug 11, 2022

justinchuby mentioned this pull request Aug 11, 2022

[ONNX] Update the default opset to version 14 #83284

Closed

justinchuby added the module: onnx Related to torch.onnx label Aug 11, 2022

justinchuby requested a review from thiagocrepaldi August 11, 2022 18:50

pytorchbot added the open source label Aug 11, 2022

justinchuby mentioned this pull request Aug 11, 2022

[ONNX] Create empty opset 17 symbolic file #83287

Closed

Update on "[ONNX] Update the script for version updates"

3e315ac

- Move script to `main()` - Add an `--skip_recompile` option - Remove file edits in `__init__` that do not work anymore [ghstack-poisoned]

justinchuby linked an issue Aug 11, 2022 that may be closed by this pull request

[ONNX] Support opset 17 operators #81075

Closed

33 tasks

justinchuby assigned justinchuby and unassigned justinchuby Aug 11, 2022

justinchuby added 2 commits August 11, 2022 19:20

Update on "[ONNX] Update the script for version updates"

98a9c0c

- Move script to `main()` - Add an `--skip_recompile` option - Remove file edits in `__init__` that do not work anymore [ghstack-poisoned]

Update on "[ONNX] Update the script for version updates"

0021d28

- Move script to `main()` - Add an `--skip_recompile` option - Remove file edits in `__init__` that do not work anymore [ghstack-poisoned]

thiagocrepaldi reviewed Aug 12, 2022

View reviewed changes

justinchuby added topic: improvements topic category topic: not user facing topic category labels Aug 12, 2022

justinchuby added release notes: onnx torch.onnx related changes that should show up in the release notes and removed topic: improvements topic category labels Aug 12, 2022

thiagocrepaldi requested changes Aug 12, 2022

View reviewed changes

tools/onnx/update_default_opset_version.py Outdated Show resolved Hide resolved

titaiwangms reviewed Aug 15, 2022

View reviewed changes

titaiwangms self-assigned this Aug 15, 2022

titaiwangms approved these changes Aug 15, 2022

View reviewed changes

justinchuby requested a review from thiagocrepaldi August 16, 2022 16:21

thiagocrepaldi approved these changes Aug 16, 2022

View reviewed changes

abock approved these changes Aug 16, 2022

View reviewed changes

pytorchmergebot pushed a commit that referenced this pull request Aug 16, 2022

[ONNX] Update the script for version updates

0ca882d

ghstack-source-id: da984a01fae8878e7ee1856c900a2f058a70507a Pull Request resolved: #83283

pytorchmergebot added the Merged label Aug 16, 2022

pytorchmergebot closed this in cd68f08 Aug 16, 2022

facebook-github-bot deleted the gh/justinchuby/6/head branch August 20, 2022 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Update the script for version updates #83283

[ONNX] Update the script for version updates #83283

justinchuby commented Aug 11, 2022 •

edited by pytorchmergebot

Loading

facebook-github-bot commented Aug 11, 2022 •

edited

Loading

thiagocrepaldi left a comment

justinchuby commented Aug 12, 2022

titaiwangms Aug 15, 2022

justinchuby Aug 16, 2022

titaiwangms left a comment

justinchuby commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

[ONNX] Update the script for version updates #83283

[ONNX] Update the script for version updates #83283

Conversation

justinchuby commented Aug 11, 2022 • edited by pytorchmergebot Loading

facebook-github-bot commented Aug 11, 2022 • edited Loading

🔗 Helpful links

✅ No Failures (0 Pending)

thiagocrepaldi left a comment

Choose a reason for hiding this comment

justinchuby commented Aug 12, 2022

titaiwangms Aug 15, 2022

Choose a reason for hiding this comment

justinchuby Aug 16, 2022

Choose a reason for hiding this comment

titaiwangms left a comment

Choose a reason for hiding this comment

justinchuby commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

justinchuby commented Aug 16, 2022

pytorchmergebot commented Aug 16, 2022

justinchuby commented Aug 11, 2022 •

edited by pytorchmergebot

Loading

facebook-github-bot commented Aug 11, 2022 •

edited

Loading