[FSDP] Pass kwargs to load_state_dict #83309
Conversation
[ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
H-Huang,
awgu and
mingzhe09088
as code owners
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 2e74d06 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
ghstack-source-id: 42d663604e889884c97db1c123ce34e3da5aa6c8 Pull Request resolved: #83309
rohan-varma
changed the title
| @@ -715,7 +715,7 @@ def test_state_dict_with_ignored_modules(self, prefix, ignore_inner): | |||
| param.zero_() | |||
|
|
|||
| to_load = {k[len(prefix_str):] : v for k, v in sd1.items()} | |||
| nonwrapped_model.load_state_dict(to_load) | |||
| nonwrapped_model.load_state_dict(to_load, strict=True) | |||
There was a problem hiding this comment.
Is it intentional to add strict=True for the non-wrapped model too?
There was a problem hiding this comment.
It wasn't, but this doesn't make a difference since strict=True is the default anyways.
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @rohan-varma. |
Summary: Pull Request resolved: #83309 Approved by: https://github.com/awgu Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/794ae6417456bedb99749a1b50ab17a9fda2b466 Reviewed By: fegin Differential Revision: D38745462 Pulled By: rohan-varma fbshipit-source-id: 33d0d6eb706d4d5095e4eb59710393adef31cba1
Stack from ghstack (oldest at bottom):