-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5/N] [Dispatchable Collectives] Update send with CPU / CUDA implementations #83859
Conversation
…tations [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit cdd1470 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…tations ghstack-source-id: 5d7d8b0090cb412069937d2b056b32647f8cce9b Pull Request resolved: #83859
…DA implementations" [ghstack-poisoned]
…tations ghstack-source-id: f205305654549ae23eab9f8ab04405d7749dcc89 Pull Request resolved: #83859
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83859
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 12 PendingAs of commit 82deaae: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
nit: missing _ at the end of function name ("send_cpu", "send_cuda").
The convention is that _ after operation means that the tensor is modified in-place. For barrier and send we do not modify the tensor, therefore those ops dont have "_" after |
I see, thanks for the education! |
…DA implementations" [ghstack-poisoned]
…DA implementations" [ghstack-poisoned]
@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
@pytorchbot merge -f "xla failure is unrelated and due to #86093" |
@pytorchbot successfully started a merge job. Check the current status here. |
Stack from ghstack:
Changes
Context
#86225
Differential Revision: D40044550