Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5/N] [Dispatchable Collectives] Update send with CPU / CUDA implementations #83859

Closed
wants to merge 15 commits into from

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Aug 22, 2022

Stack from ghstack:

Changes

  • Updates for the send collective

Context

#86225

Differential Revision: D40044550

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 22, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit cdd1470 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 22, 2022
H-Huang added a commit that referenced this pull request Aug 22, 2022
…tations

ghstack-source-id: 5d7d8b0090cb412069937d2b056b32647f8cce9b
Pull Request resolved: #83859
H-Huang added a commit that referenced this pull request Aug 22, 2022
…tations

ghstack-source-id: f205305654549ae23eab9f8ab04405d7749dcc89
Pull Request resolved: #83859
@H-Huang H-Huang requested a review from kwen2501 August 22, 2022 23:04
@H-Huang H-Huang added module: c10d Issues/PRs related to collective communications and process groups release notes: distributed (c10d) release notes category topic: new features topic category labels Aug 22, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83859

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 12 Pending

As of commit 82deaae:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

nit: missing _ at the end of function name ("send_cpu", "send_cuda").

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2022
@H-Huang
Copy link
Member Author

H-Huang commented Sep 30, 2022

nit: missing _ at the end of function name ("send_cpu", "send_cuda").

The convention is that _ after operation means that the tensor is modified in-place. For barrier and send we do not modify the tensor, therefore those ops dont have "_" after

@kwen2501
Copy link
Contributor

I see, thanks for the education!

@H-Huang
Copy link
Member Author

H-Huang commented Oct 3, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@H-Huang
Copy link
Member Author

H-Huang commented Oct 4, 2022

@pytorchbot merge -f "xla failure is unrelated and due to #86093"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/77/head branch June 8, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: c10d Issues/PRs related to collective communications and process groups oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: new features topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants